Date: Mon, 6 Jul 2020 07:43:44 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Gleb Popov <6yearold@gmail.com> Cc: "Tobias C. Berner" <tcberner@freebsd.org>, ports-committers <ports-committers@freebsd.org>, svn-ports-all <svn-ports-all@freebsd.org>, svn-ports-head <svn-ports-head@freebsd.org> Subject: Re: svn commit: r541296 - in head: databases/kexi devel/injeqt textproc/libkolabxml x11/sddm Message-ID: <20200706074344.GA10272@FreeBSD.org> In-Reply-To: <CALH631=ZugswyONhqcV8jawdO_N2p2EK2rNt2oMWiuO6=RzDoQ@mail.gmail.com> References: <202007051920.065JKLK1093017@repo.freebsd.org> <20200705192642.GA32791@FreeBSD.org> <CAOshKtcu3i9WYg_o2W_oBnwGG0Drh=VCPt%2B0E_MaPt_=pnjJog@mail.gmail.com> <CALH631=ZugswyONhqcV8jawdO_N2p2EK2rNt2oMWiuO6=RzDoQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 06, 2020 at 11:25:44AM +0400, Gleb Popov wrote: > On Mon, Jul 6, 2020 at 1:44 AM Tobias C. Berner <tcberner@freebsd.org> > wrote: > > > Well, I disagree. I find it exactly the opposite :) > > +1, CMAKE_ON gets parsed by my brain faster than -DBUILD_MAN_PAGES=ON You've missed the type, it should be -DBUILD_MAN_PAGES:BOOL=ON. :) Also, CMAKE_ON does not align nicely with <option>_CMAKE_ON which gets added to CMAKE_ARGS as is. This inconsistency alone bothers me enough to avoid using CMAKE_ON. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200706074344.GA10272>