From owner-svn-ports-all@FreeBSD.ORG Mon May 4 06:23:37 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 78555B29 for ; Mon, 4 May 2015 06:23:37 +0000 (UTC) Received: from vfemail.net (ninezero.vfemail.net [96.30.253.190]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F278D117F for ; Mon, 4 May 2015 06:23:36 +0000 (UTC) Received: (qmail 81756 invoked by uid 89); 4 May 2015 06:23:18 -0000 Received: from localhost (HELO freequeue.vfemail.net) (127.0.0.1) by localhost with (DHE-RSA-AES256-SHA encrypted) SMTP; 4 May 2015 06:23:17 -0000 Received: (qmail 81632 invoked by uid 89); 4 May 2015 06:23:00 -0000 Received: by simscan 1.3.1 ppid: 81623, pid: 81627, t: 0.0037s scanners:none Received: from unknown (HELO smtp102-2.vfemail.net) (172.16.100.62) by FreeQueue with SMTP; 4 May 2015 06:23:00 -0000 Received: (qmail 11139 invoked by uid 89); 4 May 2015 06:23:00 -0000 Received: by simscan 1.4.0 ppid: 11110, pid: 11123, t: 0.9443s scanners:none Received: from unknown (HELO nil) (amJlaWNoQHZmZW1haWwubmV0@172.16.100.27) by 172.16.100.62 with ESMTPA; 4 May 2015 06:22:59 -0000 From: Jan Beich To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r385216 - head/devel/tcllib References: <201505022018.t42KIT7q073232@svn.freebsd.org> Date: Mon, 04 May 2015 08:22:51 +0200 In-Reply-To: <201505022018.t42KIT7q073232@svn.freebsd.org> (Mathieu Arnold's message of "Sat, 2 May 2015 20:18:29 +0000 (UTC)") Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2015 06:23:37 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Mathieu Arnold writes: > Author: mat > Date: Sat May 2 20:18:29 2015 > New Revision: 385216 > URL: https://svnweb.freebsd.org/changeset/ports/385216 > > Log: > Fixup USE_GITHUB usage. [...] > @@ -17,8 +17,7 @@ OPTIONS_DEFINE=3D DOCS MANPAGES >=20=20 > USE_GITHUB=3D yes > GH_ACCOUNT=3D tcltk > -GH_PROJECT=3D tcllib > -GH_COMMIT=3D 4c7af4c > +GH_TAGNAME=3D ${PORTNAME}_${PORTVERSION:S/./_/} Why duplicate version in distinfo? This goes against Porter's Handbook "slight variation from PORTREVISION" example of using DISTVERSION*FIX. Index: devel/tcllib/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =2D-- devel/tcllib/Makefile (revision 385376) +++ devel/tcllib/Makefile (working copy) @@ -2,7 +2,8 @@ # $FreeBSD$ =20 PORTNAME=3D tcllib =2DPORTVERSION=3D 1.17 +DISTVERSIONPREFIX=3D${PORTNAME}_ +DISTVERSION=3D 1_17 CATEGORIES=3D devel tcl =20 MAINTAINER=3D tcltk@FreeBSD.org @@ -17,7 +18,6 @@ OPTIONS_DEFINE=3D DOCS MANPAGES =20 USE_GITHUB=3D yes GH_ACCOUNT=3D tcltk =2DGH_TAGNAME=3D ${PORTNAME}_${PORTVERSION:S/./_/} =20 USES+=3D tcl GNU_CONFIGURE=3D yes Index: devel/tcllib/distinfo =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =2D-- devel/tcllib/distinfo (revision 385376) +++ devel/tcllib/distinfo (working copy) @@ -1,2 +1,2 @@ =2DSHA256 (tcltk-tcllib-1.17-tcllib_1_17_GH0.tar.gz) =3D cbfbad79314e752f63= b78227a2a33e91fba1ebcabe3b69fa8d1ee6b235125043 =2DSIZE (tcltk-tcllib-1.17-tcllib_1_17_GH0.tar.gz) =3D 8284201 +SHA256 (tcltk-tcllib-tcllib_1_17_GH0.tar.gz) =3D cbfbad79314e752f63b78227a= 2a33e91fba1ebcabe3b69fa8d1ee6b235125043 +SIZE (tcltk-tcllib-tcllib_1_17_GH0.tar.gz) =3D 8284201 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJVRxA7XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bfEEIAJ3Vs4KPe4wX7Twq9+y8pjs6 CxvrKMPQgEtpCk8NIRI5QkAkw1t70Rg6kKYzNAw3IwSKr1WCbtVeTNoZ26PmK5fG M+pZId3pDIpwf1ORHNKmM71vK580jRjDci2/IZYhELZTvH8TJwrOofrwTyIlS463 eReXxDe+6W7EEsL2tov2ZVq1nt7Qz4WwaIL1qXuOGN7nZTx3jZBGQ4d8qT4/NNzU VQMRIJGvoanMsuiH4Hi+2m6AZe6hj9Lv3KbViXx09esoGPQ2jux6IWyHPqriWzb/ ylgGOFvJJEb30kqVNo13wKJITOsnk5JFVEHYdFg7vHeI6pO0Zj6IML0pglzrv8A= =Y+NH -----END PGP SIGNATURE----- --=-=-=--