From owner-freebsd-ports  Tue Oct  3 18:56:49 2000
Delivered-To: freebsd-ports@freebsd.org
Received: from ns1.sunesi.net (ns1.sunesi.net [196.15.192.194])
	by hub.freebsd.org (Postfix) with ESMTP id 5D8E937B502
	for <ports@freebsd.org>; Tue,  3 Oct 2000 18:56:45 -0700 (PDT)
Received: from nbm by ns1.sunesi.net with local (Exim 3.03 #1)
	id 13gdnK-000JbY-00; Wed, 04 Oct 2000 03:56:30 +0200
Date: Wed, 4 Oct 2000 03:56:30 +0200
From: Neil Blakey-Milner <nbm@mithrandr.moria.org>
To: Michael Lucas <mwlucas@blackhelicopters.org>
Cc: ports@freebsd.org
Subject: Re: basic ports question
Message-ID: <20001004035630.A75306@mithrandr.moria.org>
References: <20001003134048.A68307@blackhelicopters.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20001003134048.A68307@blackhelicopters.org>; from mwlucas@blackhelicopters.org on Tue, Oct 03, 2000 at 01:40:48PM -0400
Organization: Sunesi Clinical Systems
X-Operating-System: FreeBSD 3.3-RELEASE i386
X-URL: http://rucus.ru.ac.za/~nbm/
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

On Tue 2000-10-03 (13:40), Michael Lucas wrote:
> Hello,
> 
> I'm considering writing an article about modifying existing ports to
> add new functions.
> 
> Could some kind person take a look at the attached patch to
> security/snort/Makefile, and tell me if this is the proper approach?
> 
> If so, I'll send-pr it.
> 
> Thanks,
> Michael
> 
> -- 
> Michael Lucas
> mwlucas@blackhelicopters.org
> http://www.blackhelicopters.org/~mwlucas/
> Big Scary Daemons: http://www.oreillynet.com/pub/q/Big_Scary_Daemons

> *** Makefile.orig	Sat Sep  2 13:23:40 2000
> --- Makefile	Tue Oct  3 13:22:05 2000
> ***************
> *** 13,20 ****
> --- 13,29 ----
>   
>   MAINTAINER=	dirk@FreeBSD.org
>   
> + .if defined(USE_MYSQL)
> + LIB_DEPENDS+= mysqlclient.6:${PORTSDIR}/databases/mysql322-client
> + .endif
> + 
>   GNU_CONFIGURE=	yes
>   MAN8=		snort.8
> + 
> + .if defined(USE_MYSQL)
> + CONFIGURE_ARGS+= --with-mysql-includes=${LOCALBASE}/include/mysql \
> + 		 --with-mysql-libraries=${LOCALBASE}/lib/mysql
> + .endif
>   
>   post-install:
>   	${MKDIR} ${PREFIX}/share/snort

If it's a user-tuneable bit you're trying to make, it's WITH_MYSQL, not
USE_MYSQL.  USE_* is reserved for internal ports use, and WITH_* is
reserved for user-serviceable switches.

So, for example you might end up with:

.if defined(WITH_QT)
USE_QT= yes
.endif

Because the user specifies WITH_QT, so the port specifies USE_QT so that
bsd.port.mk does the right magic.

Neil
-- 
Neil Blakey-Milner
Sunesi Clinical Systems
nbm@mithrandr.moria.org


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message