From owner-freebsd-ports@FreeBSD.ORG Tue Nov 15 22:06:45 2005 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F370316A41F for ; Tue, 15 Nov 2005 22:06:44 +0000 (GMT) (envelope-from ringworm01@gmail.com) Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.200]) by mx1.FreeBSD.org (Postfix) with ESMTP id F21CE43D49 for ; Tue, 15 Nov 2005 22:06:43 +0000 (GMT) (envelope-from ringworm01@gmail.com) Received: by wproxy.gmail.com with SMTP id i12so867091wra for ; Tue, 15 Nov 2005 14:06:40 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=F5UIbzDFLt5WeJMuxF/gW0aEaYdoBB3Yc8gDdP32xaYO5kqhWsAnFAYBAumPNvs7jycYj6fZoJtOc1e5zgbRJXAsyonXf6Os4cDxXOWz3do+CSxG68z0UutPNwEFsTu2qTFcnXQUv1rEdq5E0rPdGRB/nV+60WkGk0SMNGByPhM= Received: by 10.54.160.9 with SMTP id i9mr4729346wre; Tue, 15 Nov 2005 14:06:40 -0800 (PST) Received: from ?192.168.1.10? ( [71.102.14.129]) by mx.gmail.com with ESMTP id g9sm1016740wra.2005.11.15.14.06.38; Tue, 15 Nov 2005 14:06:39 -0800 (PST) From: "Michael C. Shultz" To: Craig Boston Date: Tue, 15 Nov 2005 13:57:14 -0800 User-Agent: KMail/1.8.3 References: <200511151301.16549.ringworm01@gmail.com> <20051115212859.GA71557@nowhere> In-Reply-To: <20051115212859.GA71557@nowhere> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200511151357.16368.ringworm01@gmail.com> Cc: Scot Hetzel , Jiawei Ye , freebsd-ports@freebsd.org Subject: Re: Why does security/amavisd-new depend on db3? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Nov 2005 22:06:45 -0000 On Tuesday 15 November 2005 13:29, Craig Boston wrote: > On Tue, Nov 15, 2005 at 01:01:15PM -0800, Michael C. Shultz wrote: > > This would still be wrong: > > > > .if ${.CURDIR} == /usr/ports/databases/p5-BerkleyDB > > WITH_BDB_VER?=42 > > .endi > > > > It is equivalent to: > > > > in pkgtools.conf: > > MAKE_ARGS = { > > 'databases/p5-BerkeleyDB' => 'WITH_BDB_VER=42', > > > > in pm-020.conf > > databases/p5-BerkeleyDB|WITH_BDB_VER=42| > > Actually, those are not quite equivalent. The make.conf entry should > work around the problem. See below for details. > > > Maybe you mean to set it as a global > > value ie. without the .if ${.CURDIR} == /usr/ports/databases/p5-BerkleyDB > > wrapper? If that were the case it would still have no effect on > > security/amavisd-new where the incorrect dependency is being recorded, > > see for yourself: > > > > > > cd /usr/ports/security/amavisd-new > > /usr/ports/security/amavisd-new>grep WITH Makefile > > > > .if !defined(WITH_MILTER) || (!exists(/usr/lib/libmilter.a) > > && !exists(${PREFIX}/lib/libmilter.a)) > > .if defined(WITH_MILTER) && !defined(AMAVIS_NOAMAVIS) > > .if defined(WITH_MYSQL) > > .if defined(WITH_PGSQL) > > .if defined(WITH_LDAP) > > It would work either as a global or with the CURDIR trick, due to the > way that the dependencies are being generated. It's true that the > amavisd-new Makefile itself is unaffected by WITH_BDB_VER, but the > p5-BerkeleyDB Makefile _IS_ evaluated at some point during the install of > amavisd-new (regardless of whether it was already installed during that > step or not). > > During the install phase of amavisd-new, the +CONTENTS file is generated > in part from the output of "make package-depends-list" > > What package-depends-list does, is that for each of the LIB_DEPENDS and > RUN_DEPENDS, it will do the equivalent of this pseudo-code: > > cd ${DEPEND_PORT_DIR} && make package-depends-list Something is bugging me so I just have to mention it here: The +CONTENTS file should record how a port was built, ie historical information. Not how it might be built based on what is in the current ports tree. Instead of running package-depends-list whose outcome can change depending on settings in make.conf really the dependent port's +CONTENTS files should be parsed, that information is a historical record of how that port was built before it was installed. -Mike > > And will then print out each of its own LIB_DEPENDS and RUN_DEPENDS at > the end. The effect is that each dependent port gets visited and > evaluated, all the way up the chain (so dependencies of dependencies get > visited, etc.), and a list of all deps is produced. > > Since this all happens at install time, if portmanager or portupgrade > did not set WITH_BDB_VER in the environment before trying to install > *amavisd*, the dependencies will be wrong. The MAKE_ARGS and such don't > take effect because those tools don't know that those port directories > are being visited (it all happens during a single "make install"). > > make.conf, however, does get evaluated at every step of the way. So > when the recursive makes are processed, and the dependencies for > p5-BerkeleyDB are being queried, that variable will kick in (since > CURDIR contains databases/p5-BerkeleyDB at that point). > > Craig