From owner-freebsd-git@freebsd.org  Wed May 29 21:26:26 2019
Return-Path: <owner-freebsd-git@freebsd.org>
Delivered-To: freebsd-git@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D66AC15AE357
 for <freebsd-git@mailman.ysv.freebsd.org>;
 Wed, 29 May 2019 21:26:25 +0000 (UTC)
 (envelope-from wlosh@bsdimp.com)
Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com
 [IPv6:2607:f8b0:4864:20::733])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 1C39A88933
 for <freebsd-git@freebsd.org>; Wed, 29 May 2019 21:26:24 +0000 (UTC)
 (envelope-from wlosh@bsdimp.com)
Received: by mail-qk1-x733.google.com with SMTP id d15so2511714qkl.4
 for <freebsd-git@freebsd.org>; Wed, 29 May 2019 14:26:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=bsdimp-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=tOMG3nraAGNXjMJolTOjNh+V7N3x4hTfEC1T66f3Gss=;
 b=SST4RIEDzKAib/WaAoor4vuKBCpR6Xij+BltlFVeKurtz7Xk+zhvbvx+f6aCqOT3sV
 NF1npkZhmWLjUMEF/JVaGVJwFNBL36HM7F9dLM4yZLTI5e64tT/JRjdttu4sjbMeJBUz
 gw8YNP49UsIYOIB5EHwk7M4UVqws1C7/YKzCjq22Xde2o4rlFzw3S0cavKHI29iUkPc2
 wqQUC9bmpDU9Wi12nC2WXN9IqWvBsJp9Fi2QCmFz1bVNA7PudAAwUxKHzKvSVerPL0Hh
 C3U3GYz9MoNEWQpdLFFGscTvZEaQt4cc+gIVzvbldAs8uR5gWuSMd9T6gI6PZBflI6Vs
 ucyg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=tOMG3nraAGNXjMJolTOjNh+V7N3x4hTfEC1T66f3Gss=;
 b=H0n6PSIBssHrL+/6hzzfpUboHDiUqjFVx+TWEO/U0O4xqDIUkDBZey85i15eTFTOML
 ZOhcdtM6QHjJQIRwDV3Aq8UB3aZ4zmlnmexBH/AgGQjSPlpIFJPenK53Mw4CsJVdWItG
 p+B731FH+fjdbupdYrYOkmiMv6N8xUukmP1pti3BH0o8NOBGPLcKTV8MPS0emRdHkrSe
 HVkoCxE9XFbIEKBU/0ISz/Ei2fZXBm5yhHEt+rf+4ejb01afXvIzrPh65xefugyxnYwS
 /79hPz7OzhRymROqy7kXTR5D/jsL1UBzOUiHNUbpamEgWVK8tcA9ycUKnJKvcSYN/jXD
 ZBZA==
X-Gm-Message-State: APjAAAWye9+mgrISOBpAeKS3wY0Q8nZh02MqCd8Y4NepaSIImQB+/Eju
 DSthFUtrmJ2hUj6/kuShkeHHcBjWWww42V6KS6+FzA==
X-Google-Smtp-Source: APXvYqx1PXPflleso6Bp49PkTKWVSr6ikeClAwVItjT2wf/dyp0z2Cpy9tZaUEqDEev0F2Py1z944kqxNtKcJRguVMI=
X-Received: by 2002:a37:4b48:: with SMTP id y69mr2300qka.77.1559165184269;
 Wed, 29 May 2019 14:26:24 -0700 (PDT)
MIME-Version: 1.0
References: <8697933A-B813-4088-90B7-A84589C3CD33@freebsd.org>
 <CAPyFy2Bqg6m8D6rO+g87Wk74iBYOGfq+=t6B_VhUM26mUZXO+Q@mail.gmail.com>
 <6fb4c8cb-7f59-872e-4de6-a8a02e7c4e29@gjunka.com>
 <CAPyFy2CkyET7v6hTfhv8ZQ=+SYM_yyhtBwzM3GfS3funaDBZHQ@mail.gmail.com>
 <82938a26-892e-0459-aa23-bdcd9e318b6c@gjunka.com>
 <CAPyFy2Dm9yWepO6P8jyF+NZDA=ZUpg0tYUQ8zRTAKkVWp6cHhw@mail.gmail.com>
In-Reply-To: <CAPyFy2Dm9yWepO6P8jyF+NZDA=ZUpg0tYUQ8zRTAKkVWp6cHhw@mail.gmail.com>
From: Warner Losh <imp@bsdimp.com>
Date: Wed, 29 May 2019 15:26:13 -0600
Message-ID: <CANCZdfpoaqpNpKZrPmkdvZxMty4ZA2xj51Zu_brJrAdydDAakg@mail.gmail.com>
Subject: Re: Git handling of commit times
To: Ed Maste <emaste@freebsd.org>
Cc: Grzegorz Junka <list1@gjunka.com>, freebsd-git@freebsd.org
X-Rspamd-Queue-Id: 1C39A88933
X-Spamd-Bar: -----
Authentication-Results: mx1.freebsd.org;
 dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623
 header.b=SST4RIED
X-Spamd-Result: default: False [-5.99 / 15.00]; ARC_NA(0.00)[];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623];
 FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3];
 TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0];
 MIME_GOOD(-0.10)[multipart/alternative,text/plain];
 PREVIOUSLY_DELIVERED(0.00)[freebsd-git@freebsd.org];
 DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[];
 DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+];
 MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com];
 RCVD_IN_DNSWL_NONE(0.00)[3.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org
 : 127.0.5.0]; NEURAL_HAM_SHORT(-0.96)[-0.956,0];
 R_SPF_NA(0.00)[];
 FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com];
 MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[];
 ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US];
 FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com];
 IP_SCORE(-3.02)[ip: (-9.42), ipnet: 2607:f8b0::/32(-3.32), asn: 15169(-2.30),
 country: US(-0.06)]; RCVD_COUNT_TWO(0.00)[2]
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
X-BeenThere: freebsd-git@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion of git use in the FreeBSD project <freebsd-git.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-git>,
 <mailto:freebsd-git-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-git/>
List-Post: <mailto:freebsd-git@freebsd.org>
List-Help: <mailto:freebsd-git-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-git>,
 <mailto:freebsd-git-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 May 2019 21:26:26 -0000

On Wed, May 29, 2019 at 12:27 PM Ed Maste <emaste@freebsd.org> wrote:

> On Wed, 29 May 2019 at 13:58, Grzegorz Junka <list1@gjunka.com> wrote:
> >
> > You mean undesirable cases? Since it's only metadata for git, these are
> > not invalid per se.
>
> Not invalid from the perspective of the Git DAG, but from the
> perspective of causality and time. Yes, the git client will allow me
> to create a commit dated next week (as it should). That said it'd be
> just fine for the server to refuse to accept such a commit on the
> basis that it's not actually valid.
>

I think this is not a viable position to stake out.

The very simple work flow of

git branch -b foo
hack
git commit
<time passes>
git checkout master
git pull
git rebase -i master foo
<repeat sequence>

would setup a situation where commits are in the past. By default, rebase
commits don't have their timestamps reset. This means that you can have
commits in any sort of weird order, and they can be days, weeks, months
even years in the past depending on how long the branch took to develop.
Nobody sees this today because people using git svn have the timestamp
reset when pushing to svn because there's no notion of setting a time on
the commit. Also, resetting the time changes the hash of the commit, iirc.

Now, this isn't the 'next week' case, but it shows that trying to be too
pedantic about this will lead to issues.

> > - commit time is later than the (accurate) server time
> >
> > That would require a trip over the internet from a hook. Still doable
> > but not very user-friendly (as I mentioned earlier).
>
> Yes, this would have to be done on the server side. But, I don't think
> it's unfriendly for the server to deny a commit based on that commit
> reportedly happening in the future.
>

Depends on how far in the future. Time is an illusion. git commit time
doubly so :) But this assumes that all the world's clocks are in sync, and
they are not. minutes of difference often exist. it's a royal pita to be on
the wrong side of the sync when pushing commits upstream to a server you
have no control over the time of.


> > However, hooks may
> > be per branch, so checking time with the server could be done only for
> > example when merging/committing to a particular branch (e.g. so that
> > someone could commit without restrictions on their branch but when
> > merging with upstream branch the local time would be enforced to be
> > matched with the server time).
>
> Yeah, in this discussion I'm assuming that any such checks are
> performed only on the canonical repository, which likely holds only
> "official" branches. Forks and derived repositories are free to apply
> whatever commit hooks they see fit (or not).
>

This bit is wise.

Warner