From owner-freebsd-current@freebsd.org Sat Jan 9 06:44:22 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8552AA6899D for ; Sat, 9 Jan 2016 06:44:22 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 585CA1D62; Sat, 9 Jan 2016 06:44:22 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-io0-x234.google.com with SMTP id 77so275779060ioc.2; Fri, 08 Jan 2016 22:44:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=DCcPCWlCRQ0CMI1ikthAO7auTRrLGb+5c9F/wAoH86g=; b=ad3e2IDZH97AknQuGcHmjDypeoCPo3y14tTXUxJmdU052nhla0rgWTKW9covTGeWUZ hQPraAycEqGgQd9KIoyvWI3qn317sQzZsJS9A102vYfM6Q38KM3/az28XxgUa5y0YvCL 670HP0avrgEFlTFk2OjhJOSnc1A/B77Aw+5dBoRcWwExVI13CWe456eBjomqHkCZL9b7 9TMtNz9lGvbtmlV36dl4K6qaJhvmOMmzFfkxonDJE11l0KogVQKjZos0QzjgdoLuTECH ImM6QxRxffNiZOwr7CWl8JJl9BTNfebCMKA0Us78BUGy0czi7arzk18NcG02wUR5vvf5 3xuQ== MIME-Version: 1.0 X-Received: by 10.107.10.217 with SMTP id 86mr93139825iok.75.1452321861747; Fri, 08 Jan 2016 22:44:21 -0800 (PST) Received: by 10.36.121.202 with HTTP; Fri, 8 Jan 2016 22:44:21 -0800 (PST) In-Reply-To: <201601090453.u094rcKk002334@slippy.cwsent.com> References: <201601090453.u094rcKk002334@slippy.cwsent.com> Date: Fri, 8 Jan 2016 22:44:21 -0800 Message-ID: Subject: Re: Panic from vesa_configure() From: Adrian Chadd To: Cy Schubert , John Baldwin Cc: Jeremie Le Hen , Ryan Stone , FreeBSD Current , =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jan 2016 06:44:22 -0000 It shouldn't have changed though; you're just requesting memory to use for x86bios calls. +jhb - any ideas? -a On 8 January 2016 at 20:53, Cy Schubert wrote: > Cy Schubert writes: >> In message <201601080107.u0817kDw078603@slippy.cwsent.com>, Cy Schubert >> writes: >> > In message > c >> > om> >> > , Adrian Chadd writes: >> > > Ok, >> > > >> > > So try adding this check: >> > > >> > > vmbuf = x86bios_alloc(&offs, sizeof(*buf), M_WAITOK); >> > > if (vmbuf == NULL) { >> > > printf("%s: x86bios_alloc failed!\n", __func__); >> > > goto fail; >> > > } >> > > >> > > ... that call shouldn't be failing, but if it's truely failing on the >> > > bcopy(), the only reason is because vmbuf is NULL. >> > >> > Thanks. I'll try this. >> > >> > vesa.c hasn't changed for a while so I suspect the root cuase may be >> > somewhere else (we're probably treating the symptom here). Nice thing about >> >> > using the same mobo and cpu combination on all my machines (except >> > laptops), failures are completely reproducible. Might be a good idea to put >> >> > in a dtrace probe too. >> >> Hi Adrian, >> >> Your patch fixed the issue. I've included a dtrace probe. I suspect the >> error may be BIOS specific and the dtrace probe should help in tracking it >> down. Does this look good to commit? > > A bit of multitasking going on here. I should have included the patch. :~ > > > > > Cheers, > Cy Schubert or > FreeBSD UNIX: Web: http://www.FreeBSD.org > > The need of the many outweighs the greed of the few. >