From owner-svn-src-all@FreeBSD.ORG  Tue Jan  5 05:39:09 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E48F61065692;
	Tue,  5 Jan 2010 05:39:09 +0000 (UTC)
	(envelope-from davidxu@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id D1FC58FC19;
	Tue,  5 Jan 2010 05:39:09 +0000 (UTC)
Received: from apple.my.domain (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o055d6fO054251;
	Tue, 5 Jan 2010 05:39:08 GMT (envelope-from davidxu@freebsd.org)
Message-ID: <4B42D07A.5000803@freebsd.org>
Date: Tue, 05 Jan 2010 13:39:06 +0800
From: David Xu <davidxu@freebsd.org>
User-Agent: Thunderbird 2.0.0.9 (X11/20080612)
MIME-Version: 1.0
To: Alexander Kabaev <kabaev@gmail.com>
References: <201001050339.o053dV1j075171@svn.freebsd.org>
	<20100104233946.6d8bfa37@kan.dnsalias.net>
In-Reply-To: <20100104233946.6d8bfa37@kan.dnsalias.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r201547 - head/lib/libc/gen
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jan 2010 05:39:10 -0000

Alexander Kabaev wrote:
> Hi,
> 
> some quick questions:
> 
> FB10_COMPAT_PRIVATE is not used anywhere, why did it get committed?
> That aside, use of SYM_DEFAULT is pretty much always wrong.
> 
Yes, this needs to be cleaned.

> Also, does libthr really need to export sem_ symbols in 1.2 namespace?
> I do not think so, but there might be reasons I am missing, could you
> shed some light here?
> 

If libthr.so does not have 1.2 semaphore, a program linked against 
libthr may use 1.0 version at linking time, doesn't this cause trouble?
anyway, I am not symbol versioning expert, welcome to fix it.