From nobody Mon Aug 29 17:35:47 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MGczS1xbyz4bYJk; Mon, 29 Aug 2022 17:35:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MGczS1NTkz3Rnh; Mon, 29 Aug 2022 17:35:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661794548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=I67dzTy70+FtPqap0CCT/Q8hPIHZujkaY/8L0STj0uY=; b=egkxyea6k4mTcE77IbBAZqoclXUrBAeansVomnh8OLyklikGikD7sbjfWsH67AZ7z+5+9R I9WHcr73ClF2CtKyaXfCHsQW+aOeGOihRHS0IoI+r9bwVFHxiE/Ckh8zsNvwYLt2QU7xSC H/RiPUClrKJlb1d+g63xamvjNQrFWBN8VMeFGGPdc31cLh3cy5MS2vNiMe2BpHimdmvYIU ejhjFiP0E3sT+GJQAioD0fDB3VyPVhBZtgOE5UTb0Y3DuqB+/MXJJzSrmUpjqB4OD00StQ ZYng+NtJ+b121nwz7/1QZGtR8hcEUmLNdRlv4qG7btOsUDhGTO43sx897hghRA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MGczS0P8CzW7M; Mon, 29 Aug 2022 17:35:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 27THZlCe050196; Mon, 29 Aug 2022 17:35:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 27THZlbc050195; Mon, 29 Aug 2022 17:35:47 GMT (envelope-from git) Date: Mon, 29 Aug 2022 17:35:47 GMT Message-Id: <202208291735.27THZlbc050195@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 32faf071bd54 - main - devstat: Remove DTrace io probes lacking a BIO reference List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 32faf071bd54c0e2e1ac07700f7ea5a3d6fa8d51 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661794548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=I67dzTy70+FtPqap0CCT/Q8hPIHZujkaY/8L0STj0uY=; b=WjUkzIw+blsyadul2wRk9F2P6LezM/k5s5X6NHM1+eegk8I/l4buPxq6pwUjq0SEpUjgR0 Q75+7CjMFnDj/mmu9kjumbo8mnSm/hGoPDbNcDTQ8e5iVlsEWoV6yzkvUcvnzPet2yGgWY WvmN1jPRFZgONiVW55sIB9p5kyE78xdTIYqKw+qKhRUIamQMBUZqx6gVb4TWSzw6DRO25Q ml92qGIoUSrP2cwaG8qFcfvOi60XvcEO+DJGRMeSmFxcsyVhfkrGeipPx210B1XVbilFdK lJSj1P53kUYcrsBuK24U7L+ynoczo7sxUubAK7POLDbUwyiJ7bh2lofpIz4vqA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1661794548; a=rsa-sha256; cv=none; b=uBv3k+SopcmhkOsb2jVlcIsJyYGk0OsUztdgeqheReTXX79GlhouMg0gwjjrFS9Yt1wKLg QYslJjunNsx8kF6AA9+Rjpn/4aaEZ9M5cU2H1s18jWXvbggERTD59Cn0lSd9V2wl2RyfET kGY3ePlvZzqx5429WvsOClo68vvwFGTm2SeKP5XLHYkYJMN2kt1IJ31nvJGV3qXC7932Mf vooucVgp2ffSclpqjWocZUyjQQol+u6D1y85HvNXuQoKbc13dSLRXE+m4xp61aKPKkVebZ CqZbg6aVmgnmHtJknQLgbW+lxnmqdOb2lmZ3El+AE1myHmHuGRLCx5Lb6By4iQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=32faf071bd54c0e2e1ac07700f7ea5a3d6fa8d51 commit 32faf071bd54c0e2e1ac07700f7ea5a3d6fa8d51 Author: Mark Johnston AuthorDate: 2022-08-29 17:22:36 +0000 Commit: Mark Johnston CommitDate: 2022-08-29 17:22:36 +0000 devstat: Remove DTrace io probes lacking a BIO reference The io:::start and end probes trace individual I/O requests. Also remove the unimplemented wait-start and wait-done probes. PR: 266098 MFC after: 1 week --- sys/kern/subr_devstat.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/sys/kern/subr_devstat.c b/sys/kern/subr_devstat.c index 98a41fd179c2..7b6e778a327f 100644 --- a/sys/kern/subr_devstat.c +++ b/sys/kern/subr_devstat.c @@ -52,17 +52,9 @@ SDT_PROVIDER_DEFINE(io); SDT_PROBE_DEFINE2(io, , , start, "struct bio *", "struct devstat *"); SDT_PROBE_DEFINE2(io, , , done, "struct bio *", "struct devstat *"); -SDT_PROBE_DEFINE2(io, , , wait__start, "struct bio *", - "struct devstat *"); -SDT_PROBE_DEFINE2(io, , , wait__done, "struct bio *", - "struct devstat *"); -#define DTRACE_DEVSTAT_START() SDT_PROBE2(io, , , start, NULL, ds) #define DTRACE_DEVSTAT_BIO_START() SDT_PROBE2(io, , , start, bp, ds) -#define DTRACE_DEVSTAT_DONE() SDT_PROBE2(io, , , done, NULL, ds) #define DTRACE_DEVSTAT_BIO_DONE() SDT_PROBE2(io, , , done, bp, ds) -#define DTRACE_DEVSTAT_WAIT_START() SDT_PROBE2(io, , , wait__start, NULL, ds) -#define DTRACE_DEVSTAT_WAIT_DONE() SDT_PROBE2(io, , , wait__done, NULL, ds) static int devstat_num_devs; static long devstat_generation = 1; @@ -245,7 +237,6 @@ devstat_start_transaction(struct devstat *ds, const struct bintime *now) binuptime(&ds->busy_from); } atomic_add_rel_int(&ds->sequence0, 1); - DTRACE_DEVSTAT_START(); } void @@ -341,7 +332,6 @@ devstat_end_transaction(struct devstat *ds, uint32_t bytes, ds->end_count++; atomic_add_rel_int(&ds->sequence0, 1); - DTRACE_DEVSTAT_DONE(); } void