From owner-cvs-all Thu Aug 17 8:10:24 2000 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id A2A9937B650; Thu, 17 Aug 2000 08:10:16 -0700 (PDT) Received: (from ache@localhost) by nagual.pp.ru (8.11.0/8.11.0) id e7HFABH83254; Thu, 17 Aug 2000 19:10:11 +0400 (MSD) (envelope-from ache) Date: Thu, 17 Aug 2000 19:10:10 +0400 From: "Andrey A. Chernov" To: Brian Fundakowski Feldman Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make Makefile config.h job.c main.c Message-ID: <20000817191010.A83092@nagual.pp.ru> References: <20000817073828.A78992@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from green@FreeBSD.org on Thu, Aug 17, 2000 at 12:38:05AM -0400 Organization: Biomechanoid Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, Aug 17, 2000 at 12:38:05AM -0400, Brian Fundakowski Feldman wrote: > On Thu, 17 Aug 2000, Andrey A. Chernov wrote: > > > On Wed, Aug 16, 2000 at 04:31:44PM -0700, Brian Feldman wrote: > > > green 2000/08/16 16:31:44 PDT > > > > > > Modified files: > > > usr.bin/make Makefile config.h job.c main.c > > > Log: > > > Allow use of the ${MAKE_SHELL} variable to specify alternate shells for > > > make(1) to use. Setting it to "sh" and "ksh" are the only values which > > > work right ATM; I wouldn't expect "csh" to get you far ;) > > > > There always was ${SHELL} variable for it present in 'make', isn't ? > > To be honest, it really doesn't work right. This does, however :) This > is a very simple change, anyway; some shells require special handling > to set up, etc. If you want to make ${SHELL} work better... =) Do we want another non-standard feature to be different from the rest of the world? F.e. GNU make use ${SHELL} for this purpose too. What is exactly wrong with ${SHELL} variable? IMHO this worth fixing and not worth yet another incompatibility. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message