From owner-freebsd-arch Thu Aug 1 10:19:14 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E64237B400 for ; Thu, 1 Aug 2002 10:19:12 -0700 (PDT) Received: from mail.speakeasy.net (mail17.speakeasy.net [216.254.0.217]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8072E43E77 for ; Thu, 1 Aug 2002 10:19:11 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 13257 invoked from network); 1 Aug 2002 17:19:10 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail17.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 1 Aug 2002 17:19:10 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.5/8.12.5) with ESMTP id g71HJ9uR061248; Thu, 1 Aug 2002 13:19:09 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200208011113.42669.mi+mx@aldan.algebra.com> Date: Thu, 01 Aug 2002 13:19:10 -0400 (EDT) From: John Baldwin To: Mikhail Teterin Subject: RE: march/mcpu in bsd.cpu.mk Cc: arch@FreeBSD.org Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 01-Aug-2002 Mikhail Teterin wrote: > Index: bsd.cpu.mk > =================================================================== > RCS file: /home/ncvs/src/share/mk/bsd.cpu.mk,v > retrieving revision 1.15 > diff -U2 -r1.15 bsd.cpu.mk > --- bsd.cpu.mk 2002/07/31 03:56:03 1.15 > +++ bsd.cpu.mk 2002/08/01 15:09:35 > @@ -11,5 +11,5 @@ > # may tune support for more advanced processors. > > -.if !defined(CPUTYPE) || ${CPUTYPE} == "" > +.if (!defined(CPUTYPE) || ${CPUTYPE} == "") && ${CFLAGS:M-cpu=*} == "" This doesn't work on non-i386 and assumes too much about what the contents on _CPU_CFLAGS will be on other archs even if you did fix it to work with the settings we currently use now. You have no way of knowing that the user is using some other option that doesn't match that pattern that conflicts with _CPU_CFLAGS. CPUTYPE is optional, and part of CPUTYPE are the NO_CPU_CFLAGS and NO_CPU_COPTFLAGS variables which are very clearly documented right beside CPUTYPE in /usr/share/examples/etc/make.conf as I have already pointed out to you. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message