From owner-cvs-src@FreeBSD.ORG  Sat Dec 27 18:03:38 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6330416A4CE; Sat, 27 Dec 2003 18:03:38 -0800 (PST)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4496D43D1F; Sat, 27 Dec 2003 18:03:37 -0800 (PST)
	(envelope-from sam@errno.com)
Received: from 66.127.85.93 ([66.127.85.93])
	(authenticated bits=0)
	by ebb.errno.com (8.12.9/8.12.9) with ESMTP id hBS23aHQ042735
	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO);
	Sat, 27 Dec 2003 18:03:36 -0800 (PST)
	(envelope-from sam@errno.com)
From: Sam Leffler <sam@errno.com>
Organization: Errno Consulting
To: Mike Silbersack <silby@silby.com>
Date: Sat, 27 Dec 2003 18:03:21 -0800
User-Agent: KMail/1.5.4
References: <200312280143.hBS1hMwD065855@repoman.freebsd.org>
	<200312271751.01178.sam@errno.com> <20031227195427.Y46996@odysseus.silby.com>
In-Reply-To: <20031227195427.Y46996@odysseus.silby.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200312271803.21069.sam@errno.com>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/alpha/alpha vm_machdep.c
	src/sys/amd64/amd64         vm_machdep.c src/sys/i386/i386
	vm_machdep.c src/sys/ia64/ia64         vm_machdep.c
	src/sys/powerpc/powerpc vm_machdep.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Dec 2003 02:03:38 -0000

On Saturday 27 December 2003 05:56 pm, Mike Silbersack wrote:
> On Sat, 27 Dec 2003, Sam Leffler wrote:
> > >   Move the declaration of sfbufspeak and sfbufsused to mbuf.h,
> > >   and use imax instead of max, as sfbufspeak and sfbufsused
> > >   are signed.
> >
> > These have nothing to do with mbufs; why move the decls to mbuf.h?
> >
> > 	Sam
>
> Because I can't think of anywhere else sendfile related values would fit.
> So far our only use of sfbufs in the system is to attach them to mbufs and
> send them out via sockets.  FWIW, I'm about to overload mbstat with some
> sendfile statistics as well, because I can't think of another place that
> they would fit well.  I'm open to ideas, as long as they don't involve
> creating yet another header file.

Looks like there's an sf_buf.h.  If that's not to your liking perhaps systm.h 
or kernel.h.  Please don't pollute mbuf.h.

	Sam