From owner-freebsd-acpi@FreeBSD.ORG Mon Nov 19 23:19:42 2007 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 48C6016A419 for ; Mon, 19 Nov 2007 23:19:42 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id DA41513C442 for ; Mon, 19 Nov 2007 23:19:41 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 220448415-1834499 for multiple; Mon, 19 Nov 2007 18:19:30 -0500 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id lAJNJRkY031973; Mon, 19 Nov 2007 18:19:28 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-acpi@freebsd.org, Jessica Mahoney Date: Mon, 19 Nov 2007 18:19:15 -0500 User-Agent: KMail/1.9.6 References: <200711192240.lAJMe3Sg075715@freefall.freebsd.org> In-Reply-To: <200711192240.lAJMe3Sg075715@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200711191819.16152.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 19 Nov 2007 18:19:28 -0500 (EST) X-Virus-Scanned: ClamAV 0.91.2/4846/Mon Nov 19 13:26:19 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Subject: Re: kern/117591: [acpi][panic] Divide by zero bug in ACPI X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2007 23:19:42 -0000 On Monday 19 November 2007 05:40:03 pm Jessica Mahoney wrote: > The following reply was made to PR kern/117591; it has been noted by GNATS. > > From: Jessica Mahoney > To: John Baldwin , bug-followup@FreeBSD.org > Cc: > Subject: Re: kern/117591: [acpi][panic] Divide by zero bug in ACPI > Date: Mon, 19 Nov 2007 17:06:40 -0500 > > John Baldwin wrote: > > Can you get a stack trace? > > > > > Tracing pid 878 tid 100080 td 0xc3f26440 > acpi_battery_get_battinfo(c3a27980,c3ee4d00,e51e1c60,c3ee4d00,0,...) at > acpi_battery_get_battinfo+0x26f > acpi_battery_ioctl(c0a44203,c3ee4d00,0,c40ec880,e51e1c08,...) at > acpi_battery_ioctl+0x14b > acpiioctl(c3a9e900,c0a44203,c3ee4d00,3,c3f26440,...) at acpiioctl_0xdd > devfs_ioctl_f(c3e35d80,c0a44203,c3ee4d00,c3ee5800,c3f26440,...) at > devfs_ioctl_f+0xcb > kern_ioctl(c3f26440,3,c0a44203,c3ee4d00,1000a24,..._ at kern_ioctl+0x355 > ioctl(c3f26440,e51e1cfc,c,c3f26440,e51e1d2c,...) at ioctl+0x134 > syscall(e51e1d38) at syscall+0x345 > Xint0x80_syscall() at Xint0x80_syscall+0x20 > --- syscall (54, FreeBSD ELF32, ioctl), eip = 0x2815289b, esp = > 0xbfbfec3c, ebp = 0xbfbfed28 --- > > If there's anything else needed, please let me know and I shall provide. You can try this: Index: acpi_battery.c =================================================================== RCS file: /usr/cvs/src/sys/dev/acpica/acpi_battery.c,v retrieving revision 1.25 diff -u -r1.25 acpi_battery.c --- acpi_battery.c 9 Oct 2007 07:51:46 -0000 1.25 +++ acpi_battery.c 19 Nov 2007 23:17:48 -0000 @@ -198,8 +198,10 @@ */ if (bif->units == ACPI_BIF_UNITS_MA && bif->dvol != 0) { bst[i].rate = (bst[i].rate * bif->dvol) / 1000; +#if 0 bst[i].cap = (bst[i].cap * bif->dvol) / 1000; bif->lfcap = (bif->lfcap * bif->dvol) / 1000; +#endif } /* Calculate percent capacity remaining. */ I think the mA => mW scaling is resulting in lfcap becoming 0, but since all we want is a ratio for 'cap' so we can generate a percentage, we don't actually need to scale this. -- John Baldwin