From owner-p4-projects@FreeBSD.ORG Thu Apr 22 23:26:59 2004 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 6C5AE16A4D0; Thu, 22 Apr 2004 23:26:59 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 46E2416A4CE for ; Thu, 22 Apr 2004 23:26:59 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id C5C1A43D5A for ; Thu, 22 Apr 2004 23:26:56 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.10/8.12.9) with ESMTP id i3N6Qugr076178; Fri, 23 Apr 2004 00:26:56 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 23 Apr 2004 00:27:05 -0600 (MDT) Message-Id: <20040423.002705.51688668.imp@bsdimp.com> To: marcel@xcllnt.net From: "M. Warner Losh" In-Reply-To: <20040423060902.GA19060@dhcp01.pn.xcllnt.net> References: <200404230321.i3N3LxhW010292@repoman.freebsd.org> <20040422.233350.119859738.imp@bsdimp.com> <20040423060902.GA19060@dhcp01.pn.xcllnt.net> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: perforce@freebsd.org Subject: Re: PERFORCE change 51597 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Apr 2004 06:27:00 -0000 In message: <20040423060902.GA19060@dhcp01.pn.xcllnt.net> Marcel Moolenaar writes: : On Thu, Apr 22, 2004 at 11:33:50PM -0600, M. Warner Losh wrote: : > : ==== //depot/projects/gdb/sys/dev/pci/pci.c#7 (text+ko) ==== : > : : > : @@ -825,6 +825,12 @@ : > : if (base == 0) : > : return 1; : > : : > : + /* Sun EBus bridges contain the ranges for the devices beyond them */ : > : + if ((pci_get_class(dev) == PCIC_BRIDGE) && : > : + (pci_get_vendor(dev) == 0x108e) && : > : + (pci_get_device(dev) == 0x1000 || pci_get_device(dev) == 0x1100)) : > : + return 1; : > : + : > : start = base; : > : end = base + (1 << ln2size) - 1; : > : count = 1 << ln2size; : > : > Shouldn't the ebus bridge device be allocating the resources and : > giving them to their children? This isn't the right fix and I'd like : > to work with you to the fix at the right level... : : Yes. tmm@ is working on that. I want to see the stopgap fix committed : in the mean time to unbreak sparc64. I'm waiting to hear back from : tmm@. Don't worry. The above change is not a solution. It's a quick : fix to give us some breathing room. Fair enough. Then commit away. Warner