From owner-freebsd-bugs@freebsd.org Fri Mar 8 00:39:10 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 78C34152CAAA for ; Fri, 8 Mar 2019 00:39:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 0E82B82760 for ; Fri, 8 Mar 2019 00:39:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id B8EDF152CAA9; Fri, 8 Mar 2019 00:39:09 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7C771152CAA8 for ; Fri, 8 Mar 2019 00:39:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 16DBC8275E for ; Fri, 8 Mar 2019 00:39:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 679511AE3C for ; Fri, 8 Mar 2019 00:39:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x280d8xv094973 for ; Fri, 8 Mar 2019 00:39:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x280d8NF094972 for bugs@FreeBSD.org; Fri, 8 Mar 2019 00:39:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 236380] `auto.obj.mk` uses incorrect test for relative pathed `obj` directory. Date: Fri, 08 Mar 2019 00:39:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: 11.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: parakleta@darkreality.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2019 00:39:10 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236380 Bug ID: 236380 Summary: `auto.obj.mk` uses incorrect test for relative pathed `obj` directory. Product: Base System Version: 11.2-STABLE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: misc Assignee: bugs@FreeBSD.org Reporter: parakleta@darkreality.org If using a Makefile with the following: ``` MK_AUTO_OBJ=3Dyes .include ``` the first time `make` is run results in an error starting with: ``` make: "/usr/share/mk/auto.obj.mk" line 61: could not use obj: .OBJDIR=3D ``` This error is generated by the following block of code: ``` .OBJDIR: ${__objdir} .if ${.OBJDIR:tA} !=3D ${__objdir:tA} && ${__objdir_made:Uno:M${__objdir}/*= } !=3D ""=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 .error could not use ${__objdir}: .OBJDIR=3D${.OBJDIR} .endif ``` The reason for this is that the use of the `.OBJDIR` target changes the cur= rent directory and thus if `__objdir` is a relative path then it can no longer be found. The man page for `make` states that: =E2=80=98.OBJDIR=E2=80=99 may be modified in the makefile via the speci= al target =E2=80=98.OBJDIR=E2=80=99. In all cases, make will chdir(2) to the specified directory if it exists, and set =E2=80=98.OBJDIR=E2=80=99 and =E2=80=98PWD=E2=80=99 to that directory before executing any target= s. I believe the solution is to convert `__objdir` to an absolute path after it has been created (and thus can be found) but before changing `.OBJDIR`. Th= at is, immediately before the block of code quoted above from line 59, add the following line: ``` __objdir:=3D ${__objdir:tA} ``` After this it is no longer necessary to use absolute paths in the following test so these can be removed. --=20 You are receiving this mail because: You are the assignee for the bug.=