Date: Wed, 18 May 2011 04:32:44 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Hans Petter Selasky <hselasky@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Andriy Gapon <avg@freebsd.org> Subject: Re: svn commit: r222051 - in head/sys/dev: sound/usb usb usb/input usb/storage Message-ID: <BANLkTimVxubKOgz_0bwpFJ_%2BOHmq=iPs0g@mail.gmail.com> In-Reply-To: <201105181320.24252.hselasky@freebsd.org> References: <201105180740.p4I7eCVx066426@svn.freebsd.org> <201105181320.24252.hselasky@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 18, 2011 at 4:20 AM, Hans Petter Selasky <hselasky@freebsd.org> wrote: > On Wednesday 18 May 2011 09:40:12 Andriy Gapon wrote: >> Author: avg >> Date: Wed May 18 07:40:12 2011 >> New Revision: 222051 >> URL: http://svn.freebsd.org/changeset/base/222051 >> >> Log: >> =A0 usb: change to one-pass probing of device drivers >> >> =A0 This brings USB bus more in line with how newbus is supposed to be u= sed. >> =A0 Also, because of the two-pass probing the following message was prod= uced >> =A0 by devd in default configuration when almost any USB device was >> =A0 connected: >> =A0 =A0 =A0 Unknown USB device: vendor <> product <> bus <> >> =A0 This should be fixed now. >> >> =A0 Note that many USB device drivers pass some information from probe >> =A0 method to attach method via ivars. =A0For this to continue working w= e rely >> =A0 on the fact that the subr_bus code calls probe method of a winning d= river >> =A0 again before calling its attach method in the case where multiple >> =A0 drivers claim to support a device. =A0This is done because device >> =A0 description is set in successful probe methods and we want to get a >> correct device description from a winning driver. =A0So now this logic i= s >> re-used for setting ivars too. >> >> =A0 Reviewed by: =A0 =A0 =A0 =A0hselasky >> =A0 MFC after: =A01 month >> >> Modified: >> =A0 head/sys/dev/sound/usb/uaudio.c >> =A0 head/sys/dev/usb/input/uhid.c >> =A0 head/sys/dev/usb/input/ukbd.c >> =A0 head/sys/dev/usb/input/ums.c >> =A0 head/sys/dev/usb/storage/umass.c >> =A0 head/sys/dev/usb/storage/ustorage_fs.c >> =A0 head/sys/dev/usb/usb_device.c >> =A0 head/sys/dev/usb/usbdi.h >> > > Looks like you missed ng_ubt.c. Just do a "grep -r" for the replaced fiel= ds. The patch I sent offline to you guys was the only affected file based on a grep around /sys/... ; I based my patch on other code patterns in this commit. Thanks! -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTimVxubKOgz_0bwpFJ_%2BOHmq=iPs0g>