From owner-svn-src-all@FreeBSD.ORG Wed May 18 11:32:45 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B8B3D106564A; Wed, 18 May 2011 11:32:45 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 235EB8FC12; Wed, 18 May 2011 11:32:44 +0000 (UTC) Received: by vws18 with SMTP id 18so1372149vws.13 for ; Wed, 18 May 2011 04:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=mdfqFda1bysczYY4PKwNS7Fw8FvICNZnKmGicOPdU6A=; b=F4t/SjGCPytnMw2r1tfesPbLD4tzZbnQd03ucmzSIuzBJrAcJmZYjUl4OSED/mKwiQ GVl58Pht24KbM5SXqXz23K00Jl97aYyz7XwW2y4JArz7H0pAqzpp0mHGd7c2PwafagaF FJobA/o6ipwcWcJRDk9CueP2i13e+3XvfPiVM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=HB/bxPMP8clq2HNil9SWUv0WrBZtCeYrD98OECQ3gLQ5pDgE2CarrZBbCtQd0MGiTd yGf14Ojgf3HplnpnK2dT56Onrj1O655j2KYNMaB4UnUgejE1voYyPkwti695YAhu0DIm 7ZvjCyEQRFFh4GNVbwtoE5tWdAuFsLkiCJpmQ= MIME-Version: 1.0 Received: by 10.52.181.168 with SMTP id dx8mr2520729vdc.172.1305718364149; Wed, 18 May 2011 04:32:44 -0700 (PDT) Received: by 10.220.188.202 with HTTP; Wed, 18 May 2011 04:32:44 -0700 (PDT) In-Reply-To: <201105181320.24252.hselasky@freebsd.org> References: <201105180740.p4I7eCVx066426@svn.freebsd.org> <201105181320.24252.hselasky@freebsd.org> Date: Wed, 18 May 2011 04:32:44 -0700 Message-ID: From: Garrett Cooper To: Hans Petter Selasky Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Andriy Gapon Subject: Re: svn commit: r222051 - in head/sys/dev: sound/usb usb usb/input usb/storage X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2011 11:32:45 -0000 On Wed, May 18, 2011 at 4:20 AM, Hans Petter Selasky wrote: > On Wednesday 18 May 2011 09:40:12 Andriy Gapon wrote: >> Author: avg >> Date: Wed May 18 07:40:12 2011 >> New Revision: 222051 >> URL: http://svn.freebsd.org/changeset/base/222051 >> >> Log: >> =A0 usb: change to one-pass probing of device drivers >> >> =A0 This brings USB bus more in line with how newbus is supposed to be u= sed. >> =A0 Also, because of the two-pass probing the following message was prod= uced >> =A0 by devd in default configuration when almost any USB device was >> =A0 connected: >> =A0 =A0 =A0 Unknown USB device: vendor <> product <> bus <> >> =A0 This should be fixed now. >> >> =A0 Note that many USB device drivers pass some information from probe >> =A0 method to attach method via ivars. =A0For this to continue working w= e rely >> =A0 on the fact that the subr_bus code calls probe method of a winning d= river >> =A0 again before calling its attach method in the case where multiple >> =A0 drivers claim to support a device. =A0This is done because device >> =A0 description is set in successful probe methods and we want to get a >> correct device description from a winning driver. =A0So now this logic i= s >> re-used for setting ivars too. >> >> =A0 Reviewed by: =A0 =A0 =A0 =A0hselasky >> =A0 MFC after: =A01 month >> >> Modified: >> =A0 head/sys/dev/sound/usb/uaudio.c >> =A0 head/sys/dev/usb/input/uhid.c >> =A0 head/sys/dev/usb/input/ukbd.c >> =A0 head/sys/dev/usb/input/ums.c >> =A0 head/sys/dev/usb/storage/umass.c >> =A0 head/sys/dev/usb/storage/ustorage_fs.c >> =A0 head/sys/dev/usb/usb_device.c >> =A0 head/sys/dev/usb/usbdi.h >> > > Looks like you missed ng_ubt.c. Just do a "grep -r" for the replaced fiel= ds. The patch I sent offline to you guys was the only affected file based on a grep around /sys/... ; I based my patch on other code patterns in this commit. Thanks! -Garrett