From owner-freebsd-current@FreeBSD.ORG Sat Jun 9 17:15:57 2012 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53]) by hub.freebsd.org (Postfix) with ESMTP id 5D0191065677 for ; Sat, 9 Jun 2012 17:15:57 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from opti.dougb.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 1075A1A83C6 for ; Sat, 9 Jun 2012 17:15:34 +0000 (UTC) Message-ID: <4FD384B5.3050709@FreeBSD.org> Date: Sat, 09 Jun 2012 10:15:33 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:12.0) Gecko/20120608 Thunderbird/12.0.1 MIME-Version: 1.0 To: freebsd-current X-Enigmail-Version: 1.4.2 OpenPGP: id=D5B2F0FB Content-Type: multipart/mixed; boundary="------------000206090006090105060102" Cc: Subject: PORTS_MODULES fix X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jun 2012 17:15:57 -0000 This is a multi-part message in MIME format. --------------000206090006090105060102 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit I have recently tried the PORTS_MODULES knob, and found a problem. The ports tree searches for some dependencies by finding a binary in PATH, and that fails since by default /usr/local/ isn't there. The attached patch fixes that problem. It would be more robust to use PREFIX there instead of /usr/local explicitly, but I'm not sure how to unravel the mk maze to get that value. If anyone has a suggestion for that, I'd be happy to include it. Any objections to making this change? Doug -- This .signature sanitized for your protection --------------000206090006090105060102 Content-Type: text/plain; charset=UTF-8; name="kern.post.mk.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="kern.post.mk.diff" Index: kern.post.mk =================================================================== --- kern.post.mk (revision 236818) +++ kern.post.mk (working copy) @@ -38,7 +38,7 @@ # Handle out of tree ports .if !defined(NO_MODULES) && defined(PORTS_MODULES) -PORTSMODULESENV=SYSDIR=${SYSDIR} +PORTSMODULESENV=SYSDIR=${SYSDIR} PATH=${PATH}:/usr/local/bin:/usr/local/sbin .for __target in all install reinstall clean ${__target}: ports-${__target} ports-${__target}: --------------000206090006090105060102--