Date: Mon, 23 Aug 2004 12:19:39 -0400 From: Brian Fundakowski Feldman <green@freebsd.org> To: Doug White <dwhite@gumbysoft.com> Cc: freebsd-current@freebsd.org Subject: Re: PLEASE TEST: IPI deadlock avoidance patch Message-ID: <20040823161939.GE77326@green.homeunix.org> In-Reply-To: <20040823154119.GC77326@green.homeunix.org> References: <20040822115345.Y94593@carver.gumbysoft.com> <20040823154119.GC77326@green.homeunix.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 23, 2004 at 11:41:19AM -0400, Brian Fundakowski Feldman wrote: > On Sun, Aug 22, 2004 at 12:05:39PM -0700, Doug White wrote: > > Hey folks, > > > > If you have a reasonably fast i386 or amd64 multiprocessor and/or > > hyperthreading machine and are experiencing reproducible hangs during -j > > buildwords and other highly parallel operations, please try this patch: > > > > http://people.freebsd.org/~dwhite/smp_rv_mtx.patch > > > > This patch avoids a deadlock between the smp_rendezvous() mechanism and > > TLB shootdowns via pmap by forcing them to share a mutex. The patch has > > been tested on several multiproc Xeon systems and a dual Opteron I have > > here and is stable, but a couple of more eyeballs and varied loads > > wouldn't hurt since this will be going into RELENG_5. > > > > If there's anything glaringly wrong from a style point of view, let me > > know too. > > > > I plan on committing this late Monday or Tuesday, barring any serious > > problems. > > > > Thanks to alc for the nudge on the solution and rwatson for staying up > > late and testing it on his hardware. > > I couldn't even run portupgrade without a hard hang on my Athlon! Oops, let me clarify: "... before applying these changes." My system is very stable under normal workload after applying them, but I also could not make a -jwhatever buildworld hang for me previously like others could. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040823161939.GE77326>