From owner-svn-src-head@freebsd.org Wed Dec 20 21:05:11 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1F2ADEA4FDB; Wed, 20 Dec 2017 21:05:11 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id C10E034DE; Wed, 20 Dec 2017 21:05:10 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with ESMTPA id RlY4eUbFoS7BpRlY5eqHKv; Wed, 20 Dec 2017 14:05:09 -0700 X-Authority-Analysis: v=2.2 cv=NKylwwyg c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=ocR9PWop10UA:10 a=BWvPGDcYAAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=R67WUro0QPnyWkeQu6IA:9 a=CjuIK1q_8ugA:10 a=pxhY87DP9d2VeQe4joPk:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id D888AA13; Wed, 20 Dec 2017 13:05:07 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id vBKL57rJ041386; Wed, 20 Dec 2017 13:05:07 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id vBKL57R2041383; Wed, 20 Dec 2017 13:05:07 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201712202105.vBKL57R2041383@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Warner Losh cc: Cy Schubert , Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327037 - head/sys/dev/acpica In-Reply-To: Message from Warner Losh of "Wed, 20 Dec 2017 13:44:54 -0700." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 20 Dec 2017 13:05:07 -0800 X-CMAE-Envelope: MS4wfCj6aUWtImuqzEisYYq1E4+jjYzsFGn/DLmHcBb8C3bmM72LxqFN6ZeQiDT/Stfun1MdwyD9iWn6/jRq7x/0AnitVK+BExX5pWqCt7Neq4YxFUDOM4OA uzKUpphE7CyqZxFFfKnNZNB80j8tTi0fd8qXspcNL61ltpCuCbJ2VvDqYsAiHu4HDukwFpuugTnkbnGRYlodbDSa9ItqDMa4QsYrRMISmzWhKaucvw8sO197 j8Kwv3lIzxvxe+OwpfZgCt5vf04xijPc/odGIQQ0pfN/O31FYP6gqO8pjklAk7SMeNpoddcAHB84+GD1rj75t+yPYKUI/Md9ZcL4ML1hPsg= X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 21:05:11 -0000 In message , Warner Losh writes: > --001a1140eeb8e8b5ac0560cba79f > Content-Type: text/plain; charset="UTF-8" > > On Dec 20, 2017 1:33 PM, "Cy Schubert" wrote: > > In message <201712201914.vBKJEG68087359@repo.freebsd.org>, Warner Losh > writes: > > Author: imp > > Date: Wed Dec 20 19:14:16 2017 > > New Revision: 327037 > > URL: https://svnweb.freebsd.org/changeset/base/327037 > > > > Log: > > Simplify the code a bit. > > > > Replace clumsy for(;;) { if (foo) break; ...} with simpler > > while (!foo) { ... }. > > > > Sponsored by: Netflix > > Differential Revision: https://reviews.freebsd.org/D13546 > > > > Modified: > > head/sys/dev/acpica/acpi.c > > > > Modified: head/sys/dev/acpica/acpi.c > > ============================================================ > ================= > > = > > --- head/sys/dev/acpica/acpi.c Wed Dec 20 19:14:11 2017 > (r32703 > > 6) > > +++ head/sys/dev/acpica/acpi.c Wed Dec 20 19:14:16 2017 > (r32703 > > 7) > > @@ -1014,10 +1014,7 @@ acpi_hint_device_unit(device_t acdev, device_t > child, > > * name to see if one's resources are a subset of this device. > > */ > > line = 0; > > - for (;;) { > > - if (resource_find_dev(&line, name, &unit, "at", NULL) != 0) > > - break; > > - > > + while (resource_find_dev(&line, name, &unit, "at", NULL) == 0) { > > /* Must have an "at" for acpi or isa. */ > > resource_string_value(name, unit, "at", &s); > > if (!(strcmp(s, "acpi0") == 0 || strcmp(s, "acpi") == 0 || > > > > > Would it make sense we upline this to reduce future MFV diffs? > > > No. This is 100% FreeBSD code. My mistake then. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.