Date: Wed, 29 Feb 2012 08:46:59 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Giovanni Trematerra <giovanni.trematerra@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r232271 - head/sys/kern Message-ID: <4F4DD7F3.3040903@FreeBSD.org> In-Reply-To: <CACfq0924BFRPgHx=FBNgmtTVzMr-6tm-r1L84dHg8Y8OwzWLoQ@mail.gmail.com> References: <201202282145.q1SLjLpO093657@svn.freebsd.org> <CACfq0924BFRPgHx=FBNgmtTVzMr-6tm-r1L84dHg8Y8OwzWLoQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2012-02-28 23:11, Giovanni Trematerra wrote: > On Tue, Feb 28, 2012 at 10:45 PM, Dimitry Andric <dim@freebsd.org> wrote: >> Author: dim >> Date: Tue Feb 28 21:45:21 2012 >> New Revision: 232271 >> URL: http://svn.freebsd.org/changeset/base/232271 ... > It introduces a style(9) violation, though. > I think it should be in this way > > pipe_chmod(struct file *fp, mode_t mode, struct ucred *active_cred, > struct thread *td) > > Anyway that's not a problem I can take care of this and other style violations > during next weeks. Is there any interest in changing the other K&R definitions in this file to C99? Or does that cause too much churn? I tried to make this change as minimal as possible to make it compile. Btw, style(9) doesn't say anything about a maximum line width, maybe that should be added explicitly...:)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F4DD7F3.3040903>