From owner-svn-src-head@FreeBSD.ORG  Wed Feb 29 07:46:59 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 584CC106564A;
	Wed, 29 Feb 2012 07:46:59 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net
	[IPv6:2001:7b8:2ff:146::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 1360D8FC15;
	Wed, 29 Feb 2012 07:46:59 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7:0:bc57:d88a:c160:9c9f] (unknown
	[IPv6:2001:7b8:3a7:0:bc57:d88a:c160:9c9f])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by tensor.andric.com (Postfix) with ESMTPSA id 4C8185C37;
	Wed, 29 Feb 2012 08:46:58 +0100 (CET)
Message-ID: <4F4DD7F3.3040903@FreeBSD.org>
Date: Wed, 29 Feb 2012 08:46:59 +0100
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
	rv:11.0) Gecko/20120216 Thunderbird/11.0
MIME-Version: 1.0
To: Giovanni Trematerra <giovanni.trematerra@gmail.com>
References: <201202282145.q1SLjLpO093657@svn.freebsd.org>
	<CACfq0924BFRPgHx=FBNgmtTVzMr-6tm-r1L84dHg8Y8OwzWLoQ@mail.gmail.com>
In-Reply-To: <CACfq0924BFRPgHx=FBNgmtTVzMr-6tm-r1L84dHg8Y8OwzWLoQ@mail.gmail.com>
X-Enigmail-Version: 1.4a1pre
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r232271 - head/sys/kern
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Feb 2012 07:46:59 -0000

On 2012-02-28 23:11, Giovanni Trematerra wrote:
> On Tue, Feb 28, 2012 at 10:45 PM, Dimitry Andric <dim@freebsd.org> wrote:
>> Author: dim
>> Date: Tue Feb 28 21:45:21 2012
>> New Revision: 232271
>> URL: http://svn.freebsd.org/changeset/base/232271
...
> It introduces a style(9) violation, though.
> I think it should be in this way
> 
> pipe_chmod(struct file *fp, mode_t mode, struct ucred *active_cred,
>     struct thread *td)
> 
> Anyway that's not a problem I can take care of this and other style violations
> during next weeks.

Is there any interest in changing the other K&R definitions in this file
to C99?  Or does that cause too much churn?  I tried to make this change
as minimal as possible to make it compile.

Btw, style(9) doesn't say anything about a maximum line width, maybe
that should be added explicitly...:)