From owner-svn-src-all@freebsd.org Tue Jul 3 15:49:09 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 27AEB102B99A; Tue, 3 Jul 2018 15:49:09 +0000 (UTC) (envelope-from rb743@hermes.cam.ac.uk) Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BC48A885A2; Tue, 3 Jul 2018 15:49:08 +0000 (UTC) (envelope-from rb743@hermes.cam.ac.uk) X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: http://help.uis.cam.ac.uk/email-scanner-virus Received: from sc1.bsdpad.com ([163.172.212.18]:56129) by ppsw-33.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.159]:587) with esmtpsa (LOGIN:rb743) (TLSv1:ECDHE-RSA-AES256-SHA:256) id 1faNYB-000HbI-gR (Exim 4.91) (return-path ); Tue, 03 Jul 2018 16:49:07 +0100 Date: Tue, 3 Jul 2018 16:38:21 +0100 From: Ruslan Bukin To: John Baldwin Cc: Ruslan Bukin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335888 - in head: contrib/blacklist/bin lib/libpjdlog sbin/hastd Message-ID: <20180703153821.GA34674@bsdpad.com> References: <201807031353.w63DrsAa079940@repo.freebsd.org> <980f862d-02d0-a1ce-cf4c-1d39021013fb@FreeBSD.org> <20180703150203.GA34086@bsdpad.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) Sender: "R. Bukin" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 15:49:09 -0000 On Tue, Jul 03, 2018 at 08:21:58AM -0700, John Baldwin wrote: > On 7/3/18 8:02 AM, Ruslan Bukin wrote: > > On Tue, Jul 03, 2018 at 07:57:00AM -0700, John Baldwin wrote: > >> On 7/3/18 6:53 AM, Ruslan Bukin wrote: > >>> Author: br > >>> Date: Tue Jul 3 13:53:54 2018 > >>> New Revision: 335888 > >>> URL: https://svnweb.freebsd.org/changeset/base/335888 > >>> > >>> Log: > >>> o Ensure va_list is declared by including stdarg.h. > >>> o Also move printf.h to go after it since it does require declaration > >>> of va_list. > >>> > >>> This fixes build with latest RISC-V GNU Toolchain with GCC 8.1 > >> > >> Normal style(9) is to sort headers. Also, includes already > >> so should already have va_list defined. I think there is some other build problem > >> you are running into with GCC 8.1. Did you ensure you stripped all of the > >> 'include-fixed' headers when you updated riscv64-gcc? This seems to be an issue > >> of busted headers in the compiler and these changes should probably be reverted. > >> > > > > What do you mean stripped? Should I do something with this directory > > The xtoolchain ports and base/gcc remove these entirely since GCC usually breaks > them. You can just remove that directory if you are building by hand. > It works. Thanks! Ruslan