From owner-svn-src-head@FreeBSD.ORG Wed Dec 17 19:24:35 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B8469C3C; Wed, 17 Dec 2014 19:24:35 +0000 (UTC) Received: from mail-wi0-x22d.google.com (mail-wi0-x22d.google.com [IPv6:2a00:1450:400c:c05::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47D83F05; Wed, 17 Dec 2014 19:24:35 +0000 (UTC) Received: by mail-wi0-f173.google.com with SMTP id r20so16904411wiv.0; Wed, 17 Dec 2014 11:24:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=4kF2gg4k2egkpvOn5sE6AVWx77mZIyASY7Tq2OBCI+4=; b=F1fShIurZDT7oVDqEBpirSDOBiXuM+yGTcligP2W9wkfZcnXZMhBhR5THE6BnNpfvC SD1YfrudZ4QwWmA48R5XaoYnSPZkcvWk++Eao4Lg8IVwjC7ZeLl6hSs//I5pprSRDMlA lCCawIVl41fOwYwl99H5Sq+BQMm8OX8fvvGXr0tEsc7FfAKvP3TsYAXJVkKl8H7MB4tP cbPv+qRgWt/r5ObqbI8xLEj1c0/tyx+TOKWhNRgFIWJLKx9iSlMu0K5ybqBtr/exRh0s jec5AQZTp9tUacD3AS0RPtTvCMi5c42yoPXkbRK7kVXFUojBCIYsQgEEm6OakKClg4L/ 1mHA== MIME-Version: 1.0 X-Received: by 10.180.80.163 with SMTP id s3mr17006307wix.59.1418844273704; Wed, 17 Dec 2014 11:24:33 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.216.106.195 with HTTP; Wed, 17 Dec 2014 11:24:33 -0800 (PST) In-Reply-To: References: <201412160921.sBG9LvFY064961@svn.freebsd.org> <20141216162055.GA64273@troutmask.apl.washington.edu> Date: Wed, 17 Dec 2014 11:24:33 -0800 X-Google-Sender-Auth: cytlLUns6pz-VXUu6CoNc2CkIPo Message-ID: Subject: Re: svn commit: r275819 - in head/lib/msun: ld128 ld80 src From: Adrian Chadd To: Ed Schouten Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Steve Kargl X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Dec 2014 19:24:35 -0000 On 17 December 2014 at 07:30, Ed Schouten wrote: > Steve, > > 2014-12-16 17:20 GMT+01:00 Steve Kargl : >> This seems like a lot of code churn for very little benefit. >> >> In particular, I know that the one person working on fixing >> problems with FreeBSD's libm has a private repo and the openlibm >> and android developers base their libm off of FreeBSD's libm >> and now they'll need to resync their codebases and resolve >> conflicts. > > I'm always afraid of statements like these, as they can be brought to > the table to prevent any changes from being made. The fact that > someone else (be it Android or openlibm) uses our code should not > limit us as a project to make changes. Hopefully this change will > merge into their direction as well? > > The fact that we often do not dare to refactor our code is exactly > what puts us in the spot that a lot of our code is often not directly > reusable by others, needs to be forked and adjusted. Examples include > u_intX_t, bcopy(), etc. > >> This comment isn't true! These functions pre-date C11 by years. >> See r151865. These functions were designed to deal with gcc's >> poorly implemented I. See the paragraph above your comment. > > Keep in mind that the phrasing is intended to say that CMPLX*() and > friends are part of C11. Those do not pre-date C11. > >> Upon further inspection with md5, this change affects only a single >> file. This last paragraph appears to be an excuse for a drive-by >> commit. > > But also acts as proof that the change is harmless. I am not entirely > sure what you're trying to imply with this. Are changes that do not > affect checksums of object files are bad? Actually, the fact that the MD5 signature changed means that the binary code generated has changed, and thus it "isn't harmless." It may be, but it certainly didn't generate identical binary code. We have some active and interested math nerds involved; perhaps a drive-by shooting without including them should be avoided. -adrian