From owner-cvs-ports@FreeBSD.ORG Sun Oct 3 03:48:18 2010 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C094A1065672; Sun, 3 Oct 2010 03:48:18 +0000 (UTC) (envelope-from kris@pcbsd.org) Received: from mail.iXsystems.com (newknight.ixsystems.com [206.40.55.70]) by mx1.freebsd.org (Postfix) with ESMTP id 9AF538FC16; Sun, 3 Oct 2010 03:48:18 +0000 (UTC) Received: from mail.ixsystems.com (localhost [127.0.0.1]) by mail.iXsystems.com (Postfix) with ESMTP id F3B32A664B3; Sat, 2 Oct 2010 20:30:41 -0700 (PDT) Received: from mail.iXsystems.com ([127.0.0.1]) by mail.ixsystems.com (mail.ixsystems.com [127.0.0.1]) (amavisd-maia, port 10024) with ESMTP id 22405-04; Sat, 2 Oct 2010 20:30:41 -0700 (PDT) Received: from [192.168.0.188] (96-38-85-215.dhcp.jcsn.tn.charter.com [96.38.85.215]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.iXsystems.com (Postfix) with ESMTPSA id D9A49A664AF; Sat, 2 Oct 2010 20:30:40 -0700 (PDT) X-User-Agent: K-9 Mail for Android References: <201010011450.o91Eosvw061411@repoman.freebsd.org> <20101002172753.GA87214@FreeBSD.org> <20101002205739.GG9579@bonjour.sunpoet.net> In-Reply-To: <20101002205739.GG9579@bonjour.sunpoet.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: Kris Moore Date: Sat, 02 Oct 2010 23:30:51 -0400 To: Sunpoet Po-Chuan Hsieh , Kris Moore , Alexey Dokuchaev Message-ID: Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/x11/menu-cache Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Oct 2010 03:48:18 -0000 "Sunpoet Po-Chuan Hsieh" wrote: >On Sat, Oct 02, 2010 at 05:27:53PM +0000, Alexey Dokuchaev wrote: >> On Fri, Oct 01, 2010 at 02:50:54PM +0000, Kris Moore wrote: >> > kmoore 2010-10-01 14:50:54 UTC >> > >> > FreeBSD ports repository >> > >> > Modified files: >> > x11/menu-cache Makefile >> > Log: >> > Fix install of pkgconfig data >> >> `post-configure' target name suggests that Makefile.in's can be omitted >> from that code, since the patch is applied to generated files anyway, no? >> >> ./danfe > >Hi, > >To the best of my knowledge, we usually do *.in modification BEFORE >configure: (e.g. post-patch:). Furthermore, the replacement looks like >what USE_GNOME=gnomehack does to Makefile.in. > >I have tested the following cases: >1. Based on Makefile r1.2, change post-configure: to post-patch: >2. Add USE_GNOME=gnomehack and remove post-configure: >The "make patch" results are identical. (except .bak files) > >I did not add this port to tinderbox due to a long package-depends-list >(67 ports). But I believe the following patch should work fine. > >Kris, Would you please check if everything is OK with the attached patch? >Thanks. > >Regards, >sunpoet >-- > 4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B > Sunpoet Po-Chuan Hsieh , Fix passes tindy just fine here, committed a moment ago. Thanks for the suggestion! -- Kris Moore PC-BSD / iXsystems