From owner-cvs-all  Tue Feb 27  2: 3:57 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id A7D1B37B719; Tue, 27 Feb 2001 02:03:45 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id VAA22765;
	Tue, 27 Feb 2001 21:03:43 +1100
Date: Tue, 27 Feb 2001 21:03:41 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: Jeroen Ruigrok van der Werven <asmodai@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/etc/defaults make.conf
In-Reply-To: <200102270903.f1R93ta23067@freefall.freebsd.org>
Message-ID: <Pine.BSF.4.21.0102272056300.24660-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Tue, 27 Feb 2001, Jeroen Ruigrok van der Werven wrote:

> asmodai     2001/02/27 01:03:55 PST
> 
>   Modified files:
>     etc/defaults         make.conf 
>   Log:
>   Add -Wundef to BDECFLAGS:
>   
>   Warn if an undefined identifier is evaluated in an `#if' directive.
>   
>   Not objected to by:	bde

Actually, I do object to this.  It is idiomatic to use `#if FOO' instead
of `#ifdef FOO' if you are prepared to define FOO as nonzero if it is
defined at all (and you don't want FOO).

I also object to BDECFLAGS being defined unconditionally in
/etc/defaults/make.conf (unlike all the other namespace pollution
suggested there), not to mention the existence of BDECFLAGS (I
put the flags in a shell script) and the abuse of make.conf to
configure things other than make(1) :-).

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message