From owner-cvs-all@FreeBSD.ORG Tue Feb 20 16:11:07 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EB7D316B2B0; Tue, 20 Feb 2007 16:11:07 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.187]) by mx1.freebsd.org (Postfix) with ESMTP id 71B4D13C46B; Tue, 20 Feb 2007 16:11:07 +0000 (UTC) (envelope-from max@love2party.net) Received: from [88.66.29.26] (helo=amd64.laiers.local) by mrelayeu.kundenserver.de (node=mrelayeu8) with ESMTP (Nemesis), id 0ML31I-1HJXa60n5r-0006mG; Tue, 20 Feb 2007 17:11:06 +0100 From: Max Laier Organization: FreeBSD To: Luigi Rizzo Date: Tue, 20 Feb 2007 17:10:59 +0100 User-Agent: KMail/1.9.5 References: <200702201545.l1KFjxF8052100@repoman.freebsd.org> In-Reply-To: <200702201545.l1KFjxF8052100@repoman.freebsd.org> X-Face: ,,8R(x[kmU]tKN@>gtH1yQE4aslGdu+2]; R]*pL,U>^H?)gW@49@wdJ`H<=?utf-8?q?=25=7D*=5FBD=0A=09U=5For=3D=5CmOZf764=26nYj=3DJYbR1PW0ud?=>|!~,,CPC.1-D$FG@0h3#'5"k{V]a~.<=?utf-8?q?mZ=7D44=23Se=7Em=0A=09Fe=7E=5C=5DX5B=5D=5Fxj?=(ykz9QKMw_l0C2AQ]}Ym8)fU MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1587711.O8jXnCBnMp"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200702201711.05599.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de login:61c499deaeeba3ba5be80f48ecc83056 X-Provags-ID2: V01U2FsdGVkX18pR6lJYpi606JzunqXXkVaUmlmh0TbL2HkZFBePtWNis3SiWbBKEFRw+CcoN8Odm+CjcX+es4L3IDrpcPfl5FurYhiCTg81x0YBZOln5tgZA== Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/iwi if_iwi.c if_iwivar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Feb 2007 16:11:08 -0000 --nextPart1587711.O8jXnCBnMp Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tuesday 20 February 2007 16:45, Luigi Rizzo wrote: > luigi 2007-02-20 15:45:59 UTC > > FreeBSD src repository > > Modified files: > sys/dev/iwi if_iwi.c if_iwivar.h > Log: > Address a few issues with the iwi driver, namely: =2E.. > + add debugging code IWI_LOCK_ASSERT() to detect missing locks. > These only do a printf, and should go away once we figure out why > the driver sometimes freezes the system due to a (yet unidentified) > race condition. > > + add a device_printf() in iwi_ioctl() in certain conditions > (see comment in the code). This helps preventing the race > condition mentioned above, and makes the system survive. This printf > will also go away once fixing this bug is completed. =2E.. > The bugs fixed by this commit (the freezing one especially) are > serious enough to call for a quick MFC =2E.. but since it is only a stopgap sollution, shouldn't we try to figure= =20 this out in HEAD and MFC the proper sollution once we found it? > MFC after: 3 days > > Revision Changes Path > 1.47 +127 -78 src/sys/dev/iwi/if_iwi.c > 1.13 +20 -0 src/sys/dev/iwi/if_iwivar.h =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart1587711.O8jXnCBnMp Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQBF2x2ZXyyEoT62BG0RAi7uAJsESUCaqtiCpfURY6H1w/lSphE6MgCfUg64 kBv9EPuUPVKGBxdKqeiOT6c= =HBib -----END PGP SIGNATURE----- --nextPart1587711.O8jXnCBnMp--