From owner-freebsd-hackers Wed Feb 26 18:19:34 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id SAA22614 for hackers-outgoing; Wed, 26 Feb 1997 18:19:34 -0800 (PST) Received: from awfulhak.demon.co.uk (awfulhak.demon.co.uk [158.152.17.1]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id SAA22597; Wed, 26 Feb 1997 18:19:13 -0800 (PST) Received: from awfulhak.demon.co.uk (localhost.lan.awfulhak.org [127.0.0.1]) by awfulhak.demon.co.uk (8.8.5/8.8.5) with ESMTP id BAA04393; Thu, 27 Feb 1997 01:23:31 GMT Message-Id: <199702270123.BAA04393@awfulhak.demon.co.uk> X-Mailer: exmh version 1.6.9 8/22/96 To: hackers@freebsd.org cc: eivind@freebsd.org, bde@zeta.org.au, brian@utell.co.uk Subject: Include files (in ppp) Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 27 Feb 1997 01:23:31 +0000 From: Brian Somers Sender: owner-hackers@freebsd.org X-Loop: FreeBSD.org Precedence: bulk Sorry to approach things like this, but I'm too green to argue. I think a vote would be more in order. In one corner, we have the argument that (iij)ppp has got so many #ifs #buts and #thens, that the additional osreldate.h dependency doesn't make things any worse. It has ifs for bsdi, NetBSD and even FreeBSD, not to mention _BSDI_VERSION and BSD... The advantage of the __FreeBSD_version inclusion is that the -current version compiles on 2.1.* In the other corner, we have the argument that as ppp is part of the system, it shouldn't have all this stuff in there. osreldate et. al. is for ports, not the system itself. I'd suggest one of the following: - Leave it as it is (with osreldate.h adding partially to the chaos) - Remove all of the #ifs buts and whys (rationalle: If osreldate isn't in there, All the #if BSD etc stuff is useless anyway) I'm going to (hide in) Munich for the weekend, I'll be back Tuesday and will go with whatever's decided. -- Brian , Don't _EVER_ lose your sense of humour....