From owner-svn-src-all@freebsd.org Mon Oct 3 17:36:26 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A2413AF3FBB; Mon, 3 Oct 2016 17:36:26 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f41.google.com (mail-it0-f41.google.com [209.85.214.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 75A0BF1E; Mon, 3 Oct 2016 17:36:26 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f41.google.com with SMTP id r192so122099249ita.0; Mon, 03 Oct 2016 10:36:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=tQMleD30dx0zSkdAHQcM75Dpphl8u3/8GVizOZC9FyM=; b=iHZ7dET0SNVyw9A1G3jR/rGDbfXhZCoDVn/zV2T07hOpbPxEgAQDfvfqO4AAKcsZLW rdKeT+MxzeYqDc8f3gS8gL6fXYR73Y62i7CI7ZG4nbiHJYq8iMQGSRGyLUzQYmCho48T xbh6bXR8lz/dDbyon7fLE0QirxT8hseaCcZTyY1+FYQFq/YexJ7arE+OITSH8VSyzJTl jrQnvIa6VZW2lnw7MqbL4VLAqsSnRMYUG3CkBb4Fe6CAdSUmNbgjvkMniDxhfTCRDCbS gnDyAMW89nHLIWwn5x07fBFQe4PHNeljFoDHbyOT9BLleRlkdlPJiYlBvCRPjq+XEx+d HFWA== X-Gm-Message-State: AA6/9RneiSNvjgaDvcfjE1R3aJqfUqARW8zrfs58SfIXqne0Y5XptafgOBVCvFO/JVdR3A== X-Received: by 10.36.37.20 with SMTP id g20mr17322443itg.63.1475513043210; Mon, 03 Oct 2016 09:44:03 -0700 (PDT) Received: from mail-it0-f48.google.com (mail-it0-f48.google.com. [209.85.214.48]) by smtp.gmail.com with ESMTPSA id 63sm7902207itz.7.2016.10.03.09.44.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Oct 2016 09:44:03 -0700 (PDT) Received: by mail-it0-f48.google.com with SMTP id o19so102674681ito.1; Mon, 03 Oct 2016 09:44:03 -0700 (PDT) X-Received: by 10.36.250.131 with SMTP id v125mr11463577ith.104.1475513042614; Mon, 03 Oct 2016 09:44:02 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.36.220.129 with HTTP; Mon, 3 Oct 2016 09:44:02 -0700 (PDT) In-Reply-To: <201610030146.u931klQS063311@repo.freebsd.org> References: <201610030146.u931klQS063311@repo.freebsd.org> From: Conrad Meyer Date: Mon, 3 Oct 2016 09:44:02 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r306620 - head/usr.bin/mkimg To: Marcel Moolenaar Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Oct 2016 17:36:26 -0000 On Sun, Oct 2, 2016 at 6:46 PM, Marcel Moolenaar wrote: > Author: marcel > Date: Mon Oct 3 01:46:47 2016 > New Revision: 306620 > URL: https://svnweb.freebsd.org/changeset/base/306620 > > Log: > Replace STAILQ with TAILQ. TAILQs are portable enough that they can > be used on both macOS and Linux. STAILQs are not. In particular, > STAILQ_LAST does not next on Linux. Since neither STAILQ_FOREACH_SAFE > nor TAILQ_FOREACH_SAFE exist on Linux, replace its use with a regular > TAILQ_FOREACH. The _SAFE variant was only used for having the next > pointer in a local variable. All of these routines are available in the "libbsd" sys/queue.h. You might find other helpful portability/compatibility routines there, requiring fewer changes to the FreeBSD mkimg. Best, Conrad