Date: Mon, 11 Sep 2006 09:29:16 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: Marcin Cieslak <saper@SYSTEM.PL> Cc: emulation@FreeBSD.org, esepecesito@gmail.com, bug-followup@FreeBSD.org Subject: Re: kern/99068: [linux] Linux emulator crashed by java, when calling ioctl(fd,SIOCGIFINDEX,...) Message-ID: <20060911092916.24p6eny5ko04ckwo@webmail.leidinger.net> In-Reply-To: <45047305.7090301@SYSTEM.PL> References: <45047305.7090301@SYSTEM.PL>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Marcin Cieslak <saper@SYSTEM.PL> (from Sun, 10 Sep 2006
22:18:13 +0200):
> --- linux_ioctl.c Sun Sep 10 22:05:48 2006
> +++ linux_ioctl.c_new Sun Sep 10 22:08:24 2006
> @@ -2239,6 +2239,17 @@
> return (copyout(&flags, &ifr->ifr_flags, sizeof(flags)));
> }
>
> +static int
> +linux_ifindex(struct thread *td, struct ifnet *ifp, struct l_ifreq *ifr)
> +{
> +#if DEBUG
> + printf("Interface index: %d\n", ifp->if_index);
Minor issues: we have a linux-debug-printf-something for such
purposes. Please have a look at other places in the linux emulation
code where DEBUG is used. And it would be nice if it also tells where
this message comes from (function name).
Bye,
Alexander.
--
Max told his friend that he'd just as soon not go hiking in the hills.
Said he, "I'm an anti-climb Max."
http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060911092916.24p6eny5ko04ckwo>