From owner-freebsd-ports-bugs@freebsd.org Tue Aug 16 08:57:55 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 191B4BBA566 for ; Tue, 16 Aug 2016 08:57:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E3BF21A47 for ; Tue, 16 Aug 2016 08:57:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u7G8vsk9014903 for ; Tue, 16 Aug 2016 08:57:54 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 211773] [NEW PORT] net/mod_amd: Asterisk app_amd for FreeSWITCH Date: Tue, 16 Aug 2016 08:57:54 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, needs-patch, needs-qa X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2016 08:57:55 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211773 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs-patch --- Comment #8 from Kubilay Kocak --- Thank you =C5=A0imun, nice work :) A few (non-obvious) issues remain that high-quality ports don't exhibit. 1) Warning: 'lib/freeswitch/mod/mod_amd.so' is not stripped consider trying INSTALL_TARGET=3Dinstall-strip or using ${STRIP_CMD} That can be addressed in a post-install: target using ${STRIP_CMD} ${STAGEDIR}/path/to/file.so because the upstream Makefile doesn't have an install-strip target 2) Use at least the -AC flags with portlint (add -N for new ports like this one) for extra checks (some may be false positives, use common sense) 3) Patch out -Werror. This flag shouldn't be included by upstreams in their releases. If it ends up there anyway, it needs to be overriden with -Wno-er= ror, or, removed entirely if a bad Makefile "inadvertently" overrides user-suppl= ied variables/flags, which mod_amd appears to :[ ).=20 3) Patch the Makefile to remove the @ (silencing command) charin the line containing "@$(CC)". The build currently only produces "--- mod_amd.o ---" output when compiling, and builds should be verbose. I only noticed this because I was looking for -Werror in the compile output and couldn't find it (because the build wasn't verbose) --=20 You are receiving this mail because: You are the assignee for the bug.=