From owner-freebsd-bugs@FreeBSD.ORG  Thu Apr 24 10:20:22 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0B57C37B401; Thu, 24 Apr 2003 10:20:22 -0700 (PDT)
Received: from mta05bw.bigpond.com (mta05bw.bigpond.com [139.134.6.95])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 874A743F3F; Thu, 24 Apr 2003 10:20:17 -0700 (PDT)
	(envelope-from darrenr@reed.wattle.id.au)
Received: from CPE-61-9-164-106.vic.bigpond.net.au
          ([144.135.24.72]) by mta05bw.bigpond.com (Netscape Messaging
          Server 4.15 mta05bw Jul 16 2002 22:47:55) with SMTP id
          HDUYTP00.B7W; Fri, 25 Apr 2003 03:20:13 +1000 
Received: from CPE-203-51-164-155.vic.bigpond.net.au ([203.51.164.155]) by
	bwmam02bpa.bigpond.com(MAM V3.3.2 17/14046790); 25 Apr 2003 03:20:13
Received: (from root@localhost)h3OHK3a12084;
	Fri, 25 Apr 2003 03:20:03 +1000
From: Darren Reed <darrenr@reed.wattle.id.au>
Message-Id: <200304241719.DAA03081@avalon.reed.wattle.id.au>
In-Reply-To: <200304240719.h3O7J5RB041530@freefall.freebsd.org>
To: Ruslan Ermilov <ru@FreeBSD.org>
Date: Fri, 25 Apr 2003 03:19:57 +1000
X-Mailer: ELM [version 2.4ME+ PL99d (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
cc: simon@comsys.ntu-kpi.kiev.ua
cc: freebsd-bugs@FreeBSD.org
Subject: Re: misc/44148: installworld in 4.7-STABLE does not install IPFilter
 related header files
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Apr 2003 17:20:22 -0000


Well, the problem needs fixing.

Whether it means creating src/include/netinet/Makefile or maybe just
'magic' dependencies, the problem should not be insolvable.

What appears to need to happen is for src/include/Makefile to have
a specific .for-.endfor to build the files in include/netinet for
IPFilter.  I think people are expecting to not need this and for it
to magically happen with other dependencies.  This would not appear
to be possible.

Something like:

IPFHDRS=ip_fil.h ip_nat.h ip_state.h ip_fil_compat.h ...
...
copies:
...
.for i in ${IPFHDRS}; do
	if [ -L ${DESTDIR}/usr/include/$i ]; then \
		rm -f ${DESTDIR}/usr/include/$i
	fi
	${INSTALL} -C -o ${BINOWN} -g ${BINGRP} -m 444 $i \
	${DESTDIR}/usr/include/netinet
.endfor
...
symlinks:
...
.for i in ${IPFHDRS}; do
	rm -f ${DESTDIR}/usr/include/$i
	ln -s ../../../sys/contrib/ipfilter/netinet/$i \
	${DESTDIR}/usr/include/netinet
.endfor

Darren