From owner-freebsd-bugs Tue Nov 20 12:10:20 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 9CA4F37B419 for ; Tue, 20 Nov 2001 12:10:02 -0800 (PST) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.4/8.11.4) id fAKKA2E04242; Tue, 20 Nov 2001 12:10:02 -0800 (PST) (envelope-from gnats) Date: Tue, 20 Nov 2001 12:10:02 -0800 (PST) Message-Id: <200111202010.fAKKA2E04242@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Mikhail Teterin Subject: Re: bin/32138: better progress reporting for dump(8) Reply-To: Mikhail Teterin Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR bin/32138; it has been noted by GNATS. From: Mikhail Teterin To: iedowse@maths.tcd.ie Cc: arr@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org Subject: Re: bin/32138: better progress reporting for dump(8) Date: Tue, 20 Nov 2001 15:06:20 -0500 (EST) On 20 Nov, Ian Dowse wrote: > In message , > "Andrew R. Reiter" writes: >> >>setproctitle() should not even be used in the handler. > > Is it being called from a signal handler? It is not. Not now, not in the original PR, not in the version last sent to -arch (three weeks ago). >You can avoid this side-effect by telling setproctitle not to print the >last character, i.e: > lastlen = strlen(lastmsg); > if (lastlen > 0 && lastmsg[lastlen - 1] == '\n') > lastlen--; > setproctitle("%s: %.*s", disk, lastlen, lastmsg); Yes! That's a good one... Thanks, -mi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message