From owner-freebsd-current@FreeBSD.ORG Thu Sep 15 07:40:40 2005 Return-Path: X-Original-To: Freebsd-current@FreeBSD.org Delivered-To: Freebsd-current@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6E91F16A41F for ; Thu, 15 Sep 2005 07:40:40 +0000 (GMT) (envelope-from sos@FreeBSD.org) Received: from spider.deepcore.dk (cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk [80.166.201.166]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3DF0543D72 for ; Thu, 15 Sep 2005 07:40:29 +0000 (GMT) (envelope-from sos@FreeBSD.org) Received: from [194.192.25.136] (mac.deepcore.dk [194.192.25.136]) by spider.deepcore.dk (8.13.4/8.13.3) with ESMTP id j8F7f4Sm001097; Thu, 15 Sep 2005 09:41:04 +0200 (CEST) (envelope-from sos@FreeBSD.org) In-Reply-To: <4328D0F7.2090501@fastmail.fm> References: <1126047871.687.1.camel@localhost> <4328D0F7.2090501@fastmail.fm> Mime-Version: 1.0 (Apple Message framework v734) Content-Type: text/plain; charset=ISO-8859-1; delsp=yes; format=flowed Message-Id: <2B22BF98-3FF4-4BE5-B8FF-56BB07CDB4D9@FreeBSD.org> Content-Transfer-Encoding: quoted-printable From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= Date: Thu, 15 Sep 2005 09:40:21 +0200 To: Patrick Bowen X-Mailer: Apple Mail (2.734) X-mail-scanned: by DeepCore Virus & Spam killer v1.12 Cc: Freebsd-current@FreeBSD.org Subject: Re: ATA error on 6.0-BETA4 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 07:40:40 -0000 On 15/09/2005, at 3:40, Patrick Bowen wrote: > I've notice the same behaviour on my Dell C600. I've attached =20 > verbose dmesg's for -current and 5.4. When I boot 5.4 the CD-RW is =20 > found and I have no problems using it for either reading or =20 > writing. I hope they're useful for you. OK, please try the below patch and let me know if that helps any. > I'd like to say that I have the greatest respect for *all* of you =20 > that work at making FreeBSD the great OS that it is. I just wonder =20 > where you find the time to work on it, what with your day jobs, =20 > family responsibilities and all... I guess we have understanding environments and need for less sleep =20 than usual :) Index: ata-lowlevel.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/sys/dev/ata/ata-lowlevel.c,v retrieving revision 1.71 diff -u -r1.71 ata-lowlevel.c --- ata-lowlevel.c 14 Sep 2005 12:45:06 -0000 1.71 +++ ata-lowlevel.c 15 Sep 2005 07:35:41 -0000 @@ -278,7 +278,7 @@ /* if read data get it */ if (request->flags & ATA_R_READ) { - if (ata_wait(ch, atadev, (ATA_S_READY | ATA_S_DRQ)) < =20= 0) { + if (ata_wait(ch, atadev, ATA_S_DRQ) < 0) { device_printf(request->dev, "timeout waiting for read DRQ\n"); request->result =3D EIO; S=F8ren Schmidt sos@FreeBSD.org