From nobody Tue Aug 27 01:06:48 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wt8Wr6gYwz5TjP2; Tue, 27 Aug 2024 01:06:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wt8Wr3mtyz4m6c; Tue, 27 Aug 2024 01:06:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724720808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=awyvXD3ZPz3W6JIsbSzZPq3T3+GNsf+D2KHoRvp5JHc=; b=vieFDVG0O918VurDexQyHEeI9sW50aFHZKzXCLZQDMGhz5xKhFZW1uQ/AqqfzS7cM2Msd9 bgQXuasDd9H/Yc4fIdFvZA/Dr5eIrpGfYIrj0aDy6FQCaU0ABGTBAfoZScIoSTlFN/cXHU zudSP9aMRlYI59UO4+dLXeYLknBJuZ84lVFymdNyEyrXMCvia0CY5doMMmAEjhYkM7TAL2 SigYLKNpiVvjEvF42yOEezMASYAgmzMovrwqSoQ8+IyrZTDIHZc44Vxe/YeB+lzOOU1ayo 7IeH1I4xeYx+8dNxk/QGNRGZladAiTml7n0AvyfxJioB0v0kXtIPCkIe1CZ8zg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724720808; a=rsa-sha256; cv=none; b=Pphq2yDfEr5eJCxH8STryiTd/B9jxiDw+uqfXIsrFjv6/5pEq6iYikr2eV/sIBj1dDDYpZ 4cfphfVvIMTJssQx6d2TD8OVFfhhcP4YcMJBKb4iUVZ9QdP8DAa809jL9S69lbOmyQXUrx yrfEH0uhjoKdhwK+3kB2M7TwwCACBM/+yyoZw1ESVcvqjD2iC8DxDRs26DyHsSorxFFl8C 0f/HZVd+UI3MTioLdj4aR+a7IGSbPpwL0TG3WaTT3V3mVwnzw6YDZJSAuUO7Zttpa5N9go Z33gdiQlPT2/bs3DVyQ06OeVawYz4LvefweyJ98yRBlsSL23PErgRxNT5bcH+g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724720808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=awyvXD3ZPz3W6JIsbSzZPq3T3+GNsf+D2KHoRvp5JHc=; b=LD1rUSO8IkMftIKL37ev+yKX2zDXQlfjSDSBalN8hjoNLLgcpuXXVdpa7t+5XNdTNpFajT rAeNmTkkgS02C0TVwZnfnFe/Tg38PeAhviZ3951AXyL0BExJUIc4fL2FRMWi5xhhzDwt2C IJT7LqEXLflspNsBXIy0K+e2mwbL92hVfPLUweVFLofoe3R6yBiIf81TajJzCCFuLlt40k sI4BuBB3N75mEbUET+sTJDJUP3HfH/HyxG+y5i7/aShFDESBndV6IAGbWU4ncmyglgMijP N2dzc4NvVtqY0Hv5TzaPeSPfUiJXVFpP8FznkuxflFk4UL61jXd4oc/hsb9+1Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wt8Wr2v2TzV4R; Tue, 27 Aug 2024 01:06:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47R16m6n057535; Tue, 27 Aug 2024 01:06:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47R16mex057532; Tue, 27 Aug 2024 01:06:48 GMT (envelope-from git) Date: Tue, 27 Aug 2024 01:06:48 GMT Message-Id: <202408270106.47R16mex057532@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 1dac1524786b - stable/14 - nvme: Eliminate intel_log_temp_stats_swapbytes List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 1dac1524786b6600a2218adcebf4ad8977aa0341 Auto-Submitted: auto-generated The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=1dac1524786b6600a2218adcebf4ad8977aa0341 commit 1dac1524786b6600a2218adcebf4ad8977aa0341 Author: Warner Losh AuthorDate: 2024-04-16 22:36:47 +0000 Commit: John Baldwin CommitDate: 2024-08-26 18:31:03 +0000 nvme: Eliminate intel_log_temp_stats_swapbytes We can't post a AER for this page, so there's no need to be able to swap it to host byte order. It's not one of the standard defined pages that can post via AER, and the vendor's public docs for this temperature page don't suggest it's possible to get over or under event changes. Since nvmecontrol no longer needsd the swap routine, remove it since it's now unused. Sponsored by: Netflix Reviewed by: chuck Differential Revision: https://reviews.freebsd.org/D44659 (cherry picked from commit 97b77de2d951b4946fb3219a99c98f2dd4c0120f) --- sys/dev/nvme/nvme.h | 17 ----------------- sys/dev/nvme/nvme_ctrlr.c | 4 ---- 2 files changed, 21 deletions(-) diff --git a/sys/dev/nvme/nvme.h b/sys/dev/nvme/nvme.h index cceafc743519..45133c7a9b91 100644 --- a/sys/dev/nvme/nvme.h +++ b/sys/dev/nvme/nvme.h @@ -2225,23 +2225,6 @@ void nvme_sanitize_status_page_swapbytes( #endif } -static inline -void intel_log_temp_stats_swapbytes(struct intel_log_temp_stats *s __unused) -{ -#if _BYTE_ORDER != _LITTLE_ENDIAN - - s->current = le64toh(s->current); - s->overtemp_flag_last = le64toh(s->overtemp_flag_last); - s->overtemp_flag_life = le64toh(s->overtemp_flag_life); - s->max_temp = le64toh(s->max_temp); - s->min_temp = le64toh(s->min_temp); - /* omit _rsvd[] */ - s->max_oper_temp = le64toh(s->max_oper_temp); - s->min_oper_temp = le64toh(s->min_oper_temp); - s->est_offset = le64toh(s->est_offset); -#endif -} - static inline void nvme_resv_status_swapbytes(struct nvme_resv_status *s __unused, size_t size __unused) diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c index 52e412c5202a..5a825c10f584 100644 --- a/sys/dev/nvme/nvme_ctrlr.c +++ b/sys/dev/nvme/nvme_ctrlr.c @@ -729,10 +729,6 @@ nvme_ctrlr_async_event_log_page_cb(void *arg, const struct nvme_completion *cpl) nvme_sanitize_status_page_swapbytes( (struct nvme_sanitize_status_page *)aer->log_page_buffer); break; - case INTEL_LOG_TEMP_STATS: - intel_log_temp_stats_swapbytes( - (struct intel_log_temp_stats *)aer->log_page_buffer); - break; default: break; }