From owner-freebsd-current@freebsd.org Sat Jun 2 15:03:06 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BECF0F71D77 for ; Sat, 2 Jun 2018 15:03:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5A49786129 for ; Sat, 2 Jun 2018 15:03:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22f.google.com with SMTP id l19-v6so23292087ioj.5 for ; Sat, 02 Jun 2018 08:03:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=LnzmrS2Epis3BttWXMJXAxw5DlhEU7mrzjLmy+8tAUc=; b=CRhG+B7jGIaLOahlFU04ENmloZm0PjCT2Tz5eEtBATNJQ/vQMEL9Dh4l85ZFl+NICz +lH7lpsxqm8dyK9W5yhA830j7yCKKuB8eYwJjZaIrK3tqhUTC8Nzmofk5lvLyH3VFCfz s1bZPMyWQXMT4bDEcYTC84MTcFInH4EefwNneo5nbRGopjokkXTWDLzKmAzyK2FZ3nH1 sKWIuDmo+uSCryV8rPIABcSjt9CWE/iSCcOvu4iLDWKbf9t69DXYtpLGzC+1u5SokG// ycvx+WZCmHOK99XV127+sphBvpIskHlDO4XSOFOCphdMxo2MZVGJovGmBog+FBkG84Ne k70Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=LnzmrS2Epis3BttWXMJXAxw5DlhEU7mrzjLmy+8tAUc=; b=gy28dFzAo9U/MojPEWGQ/DNqZ2b8dLlLcbTqg1mtynqbumvcQDN+volvQnvpYyxD6T vyrApzQpM7Tp7xOgmEUmukbfMGhhlrhpZ2UrRr01zSmYT0rUnhkrC5ob86qAUy+6cJV/ 6Rmf7ZAwK3SrvXxhF/PgAZn1g0UCLotFb54tGN75AvObwkiH4ptLrk7cRC7eriF79RhI vIiFrPXWCnHQxsMRhTmSyOUpKfTkBwi+CIL2gxlI8fZD5pLjf2smZAwqUV5SZFpZEglv Br8i0TpANh6sWld6qJElagM8rFNxKH7UVqt55laVByLU23sLEsqIxw4rPp4y0TdadTRH oBdw== X-Gm-Message-State: ALKqPweZOFUphXBt2rLef8Quwwbc2gjNmDeLnYKJCm1e3kxMiU0yiZBN fxAyEmMYarG4r3iednBMxFLMnO0/sJJgNVy/iva6KBqq X-Google-Smtp-Source: ADUXVKLaSlrnEj4h40Mxca7AKfPfkqSvvphgN9H8KnBSH+saYY3gmyAUEQbBtdRlHLtWvz2dxUQdyKYeSwnAkLlRdBA= X-Received: by 2002:a6b:be01:: with SMTP id o1-v6mr14458385iof.299.1527951785378; Sat, 02 Jun 2018 08:03:05 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:d028:0:0:0:0:0 with HTTP; Sat, 2 Jun 2018 08:03:04 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <3ea085128a4e677a4d4150be18b366bd@kondratyev.su> References: <3ea085128a4e677a4d4150be18b366bd@kondratyev.su> From: Warner Losh Date: Sat, 2 Jun 2018 09:03:04 -0600 X-Google-Sender-Auth: -9VeQOVNkaRt-pWBf2ddMjmk-Qs Message-ID: Subject: Re: Proper way to remove never used ioctls To: Vladimir Kondratyev Cc: FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jun 2018 15:03:07 -0000 On Sat, Jun 2, 2018 at 7:33 AM, Vladimir Kondratyev wrote: > Hi, > > Our sys/mouse.h header has a definition of MOUSE_GETVARS and MOUSE_SETVARS > ioctls which are not documented and only stubbed in a few drivers: mse(4), > psm(4) and syscon's sysmouse(4). The only exception is MOUSE_GETVARS > implemented in psm(4) > > Given the fact that they were introduced 20 years ago, implementation was > never completed and googling on them shows no traces of usage in indexed > universe, is it acceptable to just drop both defines and implementation > w.o. leaving any COMPAT_FREEBSD shims? I'd prepare a patch just removing them. I'd then send that patch to the ports mgr team and request a exp-run. Details for that can be found in https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html Once that's done, submit a Phabricator review and send me email. I'll make sure it gets pushed in if there's no objections. Warner