From owner-cvs-all Mon Jan 28 18:15:48 2002 Delivered-To: cvs-all@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id 3288737B488; Mon, 28 Jan 2002 18:15:23 -0800 (PST) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 1968978306; Tue, 29 Jan 2002 12:45:06 +1030 (CST) Date: Tue, 29 Jan 2002 12:45:06 +1030 From: Greg Lehey To: David O'Brien Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/vinum vinumconfig.c vinumioctl.c Message-ID: <20020129124506.I37206@wantadilla.lemis.com> References: <200201270420.g0R4KrU26853@freefall.freebsd.org> <20020127145356.C41130@wantadilla.lemis.com> <20020128102214.A69546@dragon.nuxi.com> <20020129093645.H83297@wantadilla.lemis.com> <20020128153343.A72981@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020128153343.A72981@dragon.nuxi.com> User-Agent: Mutt/1.3.23i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Monday, 28 January 2002 at 15:33:43 -0800, David O'Brien wrote: > On Tue, Jan 29, 2002 at 09:36:45AM +1030, Greg Lehey wrote: >> On Monday, 28 January 2002 at 10:22:14 -0800, David O'Brien wrote: >>> On Sun, Jan 27, 2002 at 02:53:56PM +1030, Greg Lehey wrote: >>>> On Saturday, 26 January 2002 at 20:20:53 -0800, Greg Lehey wrote: >>>>> grog 2002/01/26 20:20:53 PST >>>>> >>>>> Modified files: >>>>> sys/dev/vinum vinumconfig.c vinumioctl.c >>>>> Log: >>>>> vinumioctl: Fix a double fault caused by calling setjmp() without holding the config lock. The call was in fact superfluous. >>>>> >>>>> Revision Changes Path >>>>> 1.44 +3 -1 src/sys/dev/vinum/vinumconfig.c >>>>> 1.32 +0 -3 src/sys/dev/vinum/vinumioctl.c >>>> >>>> Grrr. Wrong text. Should be: >>> >>> >>> cvs ci -f ??? >> >> Not worth it for what I had to add. > > Why not and how can you tell??? > If it was worth it to send a follow up email (as you must have felt the > information useful to *someone*) -- it is certainly proper to get that > same correction in the logs. Else someone that looks at the logs 2 years > from now will either forgotten or never saw the email I replied to. Done. *and* I forgot a Requested by:. I hope you don't want another forced commit for that :-) Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message