From owner-freebsd-arch Mon Dec 11 3:27:39 2000 From owner-freebsd-arch@FreeBSD.ORG Mon Dec 11 03:27:35 2000 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB3D337B74E for ; Mon, 11 Dec 2000 03:24:23 -0800 (PST) Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by mx1.FreeBSD.org (Postfix) with ESMTP id 40B256E3042 for ; Mon, 11 Dec 2000 02:31:26 -0800 (PST) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id eBBAU8b24268; Mon, 11 Dec 2000 02:30:08 -0800 (PST) Date: Mon, 11 Dec 2000 02:30:08 -0800 From: Alfred Perlstein To: Peter Wemm Cc: Dag-Erling Smorgrav , arch@FreeBSD.ORG Subject: Re: %a and %A formats Message-ID: <20001211023008.X16205@fw.wintelcom.net> References: <200012110959.eBB9xiK26188@mobile.wemm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200012110959.eBB9xiK26188@mobile.wemm.org>; from peter@netplex.com.au on Mon, Dec 11, 2000 at 01:59:43AM -0800 Sender: bright@fw.wintelcom.net Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * Peter Wemm [001211 01:59] wrote: > Dag-Erling Smorgrav wrote: > > Alfred Perlstein writes: > > > Glancing at it, I don't see it working properly on different > > > endianness. > > > > You're right, I didn't think about endianness. It should be a trivial > > fix (as long as you don't expect it to handle NUXI-style machines) > > Dont forget gcc's -fformat-extensions code needs to have corresponding > patches to check these keyword types. We compile the kernel with this flag > specifically for this reason. It understands all the wierd formats (eg: %B > etc). The more I think about this patch, the less I like it. While the work is good and it's probably pretty handy, the kernel really doesn't print out too many addresses afaik. A better idea would be to fix the inaddr->char* routines to be mpsafe like I've done with inet_ntoa_r(). I just don't want to wind up sometime later wondering if %Z is a good flag to use to print out an mbuf. :) -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message