From owner-svn-src-head@FreeBSD.ORG Wed Apr 15 20:15:36 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D0825106564A; Wed, 15 Apr 2009 20:15:36 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id BF44E8FC22; Wed, 15 Apr 2009 20:15:36 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n3FKFaRH053440; Wed, 15 Apr 2009 20:15:36 GMT (envelope-from ed@svn.freebsd.org) Received: (from ed@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n3FKFaax053439; Wed, 15 Apr 2009 20:15:36 GMT (envelope-from ed@svn.freebsd.org) Message-Id: <200904152015.n3FKFaax053439@svn.freebsd.org> From: Ed Schouten Date: Wed, 15 Apr 2009 20:15:36 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r191116 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2009 20:15:37 -0000 Author: ed Date: Wed Apr 15 20:15:36 2009 New Revision: 191116 URL: http://svn.freebsd.org/changeset/base/191116 Log: Remove unneeded variable and casting from newdev(). Remove the `udev' variable, which has a different type than the original function argument and si_drv0. The `udev' name is also misleading, because it is not the number returned by dev2udev(). Rename this argument to `unit'. It is the same number as returned by dev2unit(). Modified: head/sys/kern/kern_conf.c Modified: head/sys/kern/kern_conf.c ============================================================================== --- head/sys/kern/kern_conf.c Wed Apr 15 20:08:26 2009 (r191115) +++ head/sys/kern/kern_conf.c Wed Apr 15 20:15:36 2009 (r191116) @@ -513,23 +513,21 @@ notify_destroy(struct cdev *dev) } static struct cdev * -newdev(struct cdevsw *csw, int y, struct cdev *si) +newdev(struct cdevsw *csw, int unit, struct cdev *si) { struct cdev *si2; - dev_t udev; mtx_assert(&devmtx, MA_OWNED); - udev = y; if (csw->d_flags & D_NEEDMINOR) { /* We may want to return an existing device */ LIST_FOREACH(si2, &csw->d_devs, si_list) { - if (dev2unit(si2) == udev) { + if (dev2unit(si2) == unit) { dev_free_devlocked(si); return (si2); } } } - si->si_drv0 = udev; + si->si_drv0 = unit; si->si_devsw = csw; LIST_INSERT_HEAD(&csw->d_devs, si, si_list); return (si);