From owner-svn-src-all@freebsd.org  Mon Sep 19 20:14:38 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CBBCFBE1826;
 Mon, 19 Sep 2016 20:14:38 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id AB308A61;
 Mon, 19 Sep 2016 20:14:38 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net
 [73.231.226.104])
 by mail.baldwin.cx (Postfix) with ESMTPSA id B4C0410AF8C;
 Mon, 19 Sep 2016 16:14:36 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: "Conrad E. Meyer" <cem@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r305981 - head/usr.bin/cmp
Date: Mon, 19 Sep 2016 13:14:29 -0700
Message-ID: <3626154.BMQsYkeuc4@ralph.baldwin.cx>
User-Agent: KMail/4.14.10 (FreeBSD/11.0-PRERELEASE; KDE/4.14.10; amd64; ; )
In-Reply-To: <201609191613.u8JGD0GA036854@repo.freebsd.org>
References: <201609191613.u8JGD0GA036854@repo.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Mon, 19 Sep 2016 16:14:36 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Sep 2016 20:14:38 -0000

On Monday, September 19, 2016 04:13:00 PM Conrad E. Meyer wrote:
> Author: cem
> Date: Mon Sep 19 16:13:00 2016
> New Revision: 305981
> URL: https://svnweb.freebsd.org/changeset/base/305981
> 
> Log:
>   cmp(1): Capsicumify
>   
>   Reviewed by:	allanjude, bapt, oshogbo
>   Sponsored by:	Dell EMC Isilon
>   Differential Revision:	https://reviews.freebsd.org/D7912
> 
> Modified:
>   head/usr.bin/cmp/cmp.c
> 
> Modified: head/usr.bin/cmp/cmp.c
> ==============================================================================
> --- head/usr.bin/cmp/cmp.c	Mon Sep 19 16:07:32 2016	(r305980)
> +++ head/usr.bin/cmp/cmp.c	Mon Sep 19 16:13:00 2016	(r305981)
> @@ -42,15 +42,18 @@ static char sccsid[] = "@(#)cmp.c	8.3 (B
>  #include <sys/cdefs.h>
>  __FBSDID("$FreeBSD$");
>  
> +#include <sys/capsicum.h>
>  #include <sys/types.h>
>  #include <sys/stat.h>

Style nit: why is <sys/capsicum.h> first?  <sys/param.h> or <sys/types.h> should
be first (from style(9)) then remaining sys/foo.h headers are alphabetically
sorted after that.  Does <sys/capsicum.h> have to be before <sys/types.h> for some
reason?

-- 
John Baldwin