From owner-freebsd-fs@FreeBSD.ORG Mon Apr 9 02:01:29 2007 Return-Path: X-Original-To: freebsd-fs@freebsd.org Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7FD5516A404; Mon, 9 Apr 2007 02:01:29 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.174]) by mx1.freebsd.org (Postfix) with ESMTP id 11ED913C44C; Mon, 9 Apr 2007 02:01:28 +0000 (UTC) (envelope-from max@love2party.net) Received: from [88.64.185.1] (helo=amd64.laiers.local) by mrelayeu.kundenserver.de (node=mrelayeu3) with ESMTP (Nemesis), id 0MKxQS-1HajAJ0gKK-0001FJ; Mon, 09 Apr 2007 03:59:37 +0200 From: Max Laier Organization: FreeBSD To: Pawel Jakub Dawidek Date: Mon, 9 Apr 2007 03:59:24 +0200 User-Agent: KMail/1.9.5 References: <20070406025700.GB98545@garage.freebsd.pl> <20070408185312.GY63916@garage.freebsd.pl> <20070409010703.GA74547@garage.freebsd.pl> In-Reply-To: <20070409010703.GA74547@garage.freebsd.pl> X-Face: ,,8R(x[kmU]tKN@>gtH1yQE4aslGdu+2]; R]*pL,U>^H?)gW@49@wdJ`H<=?utf-8?q?=25=7D*=5FBD=0A=09U=5For=3D=5CmOZf764=26nYj=3DJYbR1PW0ud?=>|!~,,CPC.1-D$FG@0h3#'5"k{V]a~.<=?utf-8?q?mZ=7D44=23Se=7Em=0A=09Fe=7E=5C=5DX5B=5D=5Fxj?=(ykz9QKMw_l0C2AQ]}Ym8)fU MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1808063.uHuXMkA1X8"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200704090359.30493.max@love2party.net> X-Provags-ID: V01U2FsdGVkX1/9fLfBsAYjFFP8e91Uj30pyb551m14aryQZUR ModI031CAqcUbC7lB6G6yXlMcpEvWfAqPiMHt+wSk/tmW/EaYM 0V4JBSAr6uZCu33xl8CwQ== Cc: freebsd-fs@freebsd.org, Dag-Erling Sm?rgrav , freebsd-current@freebsd.org Subject: Re: ZFS committed to the FreeBSD base. X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2007 02:01:29 -0000 --nextPart1808063.uHuXMkA1X8 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Monday 09 April 2007 03:07, Pawel Jakub Dawidek wrote: > On Sun, Apr 08, 2007 at 08:53:12PM +0200, Pawel Jakub Dawidek wrote: > > fzap_upgrade() changes type from 'zap_micro' to 'zap_fat' and union > > is used for this (see > > sys/contrib/opensolaris/uts/common/fs/zfs/sys/zap_impl.h), that's why > > we see this trash: > > > > zap_num_entries_mtx =3D {lock_object =3D {lo_name =3D 0x70000
> 0x70000 out of bounds>, lo_type =3D 0x0, lo_flags =3D 2155822976, > > lo_witness_data =3D {lod_list =3D {stqe_next =3D 0x0}, lod_witness =3D = 0x0}}, > > sx_lock =3D 1, sx_recurse =3D 0}, > > > > I already use kmem_zalloc() (note _z_) for zap allocation in > > zap_micro.c, so Max is right, that we have to clear this structure > > here. > > > > I'm quite tired of tracking such problems, because our mechanism for > > detecting already initialized locks is too simple (based on one bit), > > so I'd prefer to improve it, or just add bzero() to mutex_init(). > > I just committed a fix. Now I do 13 bits check for already initialized > locks detection instead of standard 1 bit check. Could you repeat your > test? Will do tomorrow. Thanks. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart1808063.uHuXMkA1X8 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQBGGZ4CXyyEoT62BG0RAsrPAJ4wzq6erlw5IQRpsViAS3uqDm9nKwCfRBvT hmrRGWrdDA2eCrEF8WeBIzE= =ujZh -----END PGP SIGNATURE----- --nextPart1808063.uHuXMkA1X8--