From owner-freebsd-ports-bugs@FreeBSD.ORG  Sun Jun 13 10:31:08 2004
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 24CAA16A4CE
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sun, 13 Jun 2004 10:31:08 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 07B5843D58
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sun, 13 Jun 2004 10:31:08 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	i5DA0l8H006206	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Sun, 13 Jun 2004 10:00:47 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i5DA0lR2006205;
	Sun, 13 Jun 2004 10:00:47 GMT
	(envelope-from gnats)
Date: Sun, 13 Jun 2004 10:00:47 GMT
Message-Id: <200406131000.i5DA0lR2006205@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
Subject: Re: ports/67900: New port: sysutils/jail  Builds a chrooted
	environment
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Oliver Eikemeier <eikemeier@fillmore-labs.com>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Jun 2004 10:31:08 -0000

The following reply was made to PR ports/67900; it has been noted by GNATS.

From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
To: bugghy <bugghy@phenix.rootshell.be>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/67900: New port: sysutils/jail  Builds a chrooted environment
Date: Sun, 13 Jun 2004 11:55:43 +0200

 bugghy wrote:
 
 >> Synopsis:       New port: sysutils/jail  Builds a chrooted environment
 
 The term `jail' is already taken in FreeBSD, meaning something different.
 You should choose a different name and patch the port accordingly.
 
 > X INSTALL_DIR = /usr/local
 > X PERL = /usr/bin/perl
 
 Don't hard code these paths.
 
 > X-mv /tmp/jail.conf.tmp /tmp/jail.conf
 > X-install_file /tmp/jail.conf $4/etc $5 $6 $7
 > X-rm /tmp/jail.conf
 > X+mv /tmp/jail.conf.tmp /tmp/jail.conf.sample
 > X+install_file /tmp/jail.conf.sample $4/etc $5 $6 $7
 > X+rm /tmp/jail.conf.sample
 
 Hard coded names in temporary file are often open to symlink attacks. Did
 you check that there are no problems here?
 
 
 > XMASTER_SITES=                  
 > http://switch.dl.sourceforge.net/sourceforge/jail/
 
 You should use MASTER_SITE_SOURCEFORGE_EXTENDED (or without _EXTENDED) 
 here.
 
 > XNO_INSTALL_MANPAGES=   yes
 
 This does only make sense when you USE_IMAKE.
 
 > Xpost-install:
 > X.if !defined(NOPORTDOCS)
 > X       ${MKDIR} ${DOCSDIR}
 > X       ${INSTALL_MAN} ${WRKSRC}/../doc/CHANGELOG ${DOCSDIR}
 > X       ${INSTALL_MAN} [...]
 
 These are not MAN pages, but DATA.
 
 > X       @${CAT} ${PKGMESSAGE}
 > X.endif
 
 This should not be conditionalized on NOPORTDOCS.
 
 > Xbin/jail
 
 See above. Please don't use `jail'.
 
 > X###################################################################
 > X# Installed additional documentation in: ${PREFIX}/share/doc/jail #
 > X# Copy ${PREFIX}/etc/jail.conf.sample to ${PREFIX}/etc/jail.conf  #
 > X###################################################################
 
 You could ${SED} %%PREFIX%% by its real value here.
 
 Another not: it seems like this port needs perl, but I haven't seen any
 USE_PERL5 here.