Date: Tue, 06 Nov 2012 12:27:37 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Gerald Pfeifer <gerald@FreeBSD.org> Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: svn commit: r307045 - head/Mk Message-ID: <5098E619.3070902@FreeBSD.org> References: <201211060023.qA60NhFW028290@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Gerald Pfeifer said: > Author: gerald > Date: Tue Nov 6 00:23:43 2012 > New Revision: 307045 > URL: http://svnweb.freebsd.org/changeset/ports/307045 > > Log: > In addition to CFLAGS and LDFLAGS now also CXXFLAGS set an rpath to > the GCC run-time. > > This extends revision r246991 (2010-01-02) and should not be necessary > in most cases since LDFLAGS already covers linking, but one can always Rather than adding this flag to CXXFLAGS why not drop it from CFLAGS? There is no place for linker options in compilation flags. > compile and link in one swoop, and this makes things consistent between > C and C++. This is a strange argument. When one does compilation and linking in one swoop one uses both CFLAGS/CXXFLAGS and LDFLAGS. In non-broken software there is never a dependency on linker flags auto-magically appearing in CFLAGS/CXXFLAGS. Besides, as we discussed before, -Wl in CFLAGS/CXXFLAGS breaks header pre-compilation with GCC. So I was surprised to see this commit. > Feature safe: yes > > Modified: > head/Mk/bsd.gcc.mk > > Modified: head/Mk/bsd.gcc.mk > ============================================================================== > --- head/Mk/bsd.gcc.mk Mon Nov 5 22:48:07 2012 (r307044) > +++ head/Mk/bsd.gcc.mk Tue Nov 6 00:23:43 2012 (r307045) > @@ -202,6 +202,7 @@ CPP:= cpp${V} > . if ${_USE_GCC} != 3.4 > _GCC_RUNTIME:= ${LOCALBASE}/lib/gcc${V} > CFLAGS+= -Wl,-rpath=${_GCC_RUNTIME} > +CXXFLAGS+= -Wl,-rpath=${_GCC_RUNTIME} > LDFLAGS+= -Wl,-rpath=${_GCC_RUNTIME} > . if defined (USE_FORTRAN) > . if ${USE_FORTRAN} == yes -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5098E619.3070902>