From owner-svn-src-all@FreeBSD.ORG Wed Nov 2 17:40:11 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3E8911065670 for ; Wed, 2 Nov 2011 17:40:11 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id F1F688FC19 for ; Wed, 2 Nov 2011 17:40:10 +0000 (UTC) Received: by vcbfk26 with SMTP id fk26so590677vcb.13 for ; Wed, 02 Nov 2011 10:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=uZV9GqRUPo+BfQIR05/yGllu2O5CHkcnwi4/v1IHs4c=; b=dyFg2N26v5O9kNbRm5cbUJ+t001haFKXLRiEZ8T1Xq8o7oebvo3VkrdQOpKRMpxiMV cQnqSx+AZXicqB1ShQruBMrONfjzuSCAhLlohT6oJTb5dk32WZihAf7eB1Pc5eTEfiB1 7/4aXL2itMMHtgz/swj2c5TiUF499QuXLFPg8= MIME-Version: 1.0 Received: by 10.182.17.103 with SMTP id n7mr1079639obd.68.1320255609993; Wed, 02 Nov 2011 10:40:09 -0700 (PDT) Received: by 10.182.89.41 with HTTP; Wed, 2 Nov 2011 10:40:09 -0700 (PDT) In-Reply-To: <4EB1712C.9000309@citrin.ru> References: <201110161508.p9GF8hIc067651@svn.freebsd.org> <4EB1712C.9000309@citrin.ru> Date: Wed, 2 Nov 2011 20:40:09 +0300 Message-ID: From: Sergey Kandaurov To: Anton Yuzhaninov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-all@freebsd.org, Andre Oppermann Subject: Re: svn commit: r226437 - head/sys/netinet X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2011 17:40:11 -0000 On 2 November 2011 20:34, Anton Yuzhaninov wrote: > On 10/16/11 19:08, Andre Oppermann wrote: >> >> Author: andre >> Date: Sun Oct 16 15:08:43 2011 >> New Revision: 226437 >> URL: http://svn.freebsd.org/changeset/base/226437 >> >> Log: >> =A0 VNET virtualize tcp_sendspace/tcp_recvspace and change the >> =A0 type to INT. =A0A long is not necessary as the TCP window is >> =A0 limited to 2**30. =A0A larger initial window isn't useful. > > In this commit sysctl renamed > from net.inet.tcp.sendspace to net.inet.tcp.tcp_sendspace > and from net.inet.tcp.recvspace to net.inet.tcp.tcp_recvspace > > This break POLA without any benefits. > Please revert sysctl rename. That was rather done accidentally as these names also match in-kernel variables which hold the corresponding sysctl values. --=20 wbr, pluknet