Date: Wed, 20 Jul 2022 18:08:06 +0000 From: bugzilla-noreply@freebsd.org To: chromium@FreeBSD.org Subject: [Bug 265180] www/chromium: actually use the system-installed ICU Message-ID: <bug-265180-28929-niU11RekEi@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-265180-28929@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265180 Mikhail T. <mi@ALDAN.algebra.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|Closed |Open --- Comment #7 from Mikhail T. <mi@ALDAN.algebra.com> --- The committed change is insufficient -- instead of using the headers installed by devel/icu, the port still uses the bundled ones. A simple experiment: 1. make patch 2. Edit the ${WRKSRC}/third_party/icu/source/common/unicode/utypes.h to insert the line at the beginning: #error Meow-meow 3. make 4. Observe the build failing with: ../../third_party/icu/source/common/unicode/utypes.h:1:2: error: Meow-meow As I mentioned in Comment #5, this -- taking declarations from one source and definitions from another -- is dangerous. Please, consider using my patch -- or some derivative thereof -- instead. -- You are receiving this mail because: You are the assignee for the bug.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-265180-28929-niU11RekEi>