Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 03 Jun 2014 10:44:38 -0500
From:      "Drewery, Bryan" <bdrewery@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Martin Wilke <miwi@freebsd.org>, ports-committers@freebsd.org
Subject:   Re: svn commit: r354497 - head/sysutils/pear-Cache_Lite
Message-ID:  <538DED66.6060501@FreeBSD.org>
In-Reply-To: <20140603012726.GA60685@FreeBSD.org>
References:  <201405190713.s4J7DAuF096825@svn.freebsd.org> <20140603012726.GA60685@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon Jun  2 20:27:26 2014, Alexey Dokuchaev wrote:
> On Mon, May 19, 2014 at 07:13:10AM +0000, Martin Wilke wrote:
>> New Revision: 354497
>> URL: http://svnweb.freebsd.org/changeset/ports/354497
>> QAT: https://qat.redports.org/buildarchive/r354497/
>>
>> +++ head/sysutils/pear-Cache_Lite/pkg-descr	Mon May 19 07:13:10 2014	(r354497)
>> @@ -1,4 +1,4 @@
>>   This package is a little cache system optimized for file containers. It is
>>   fast and safe (because it uses file locking and/or anti-corruption tests).
>>
>> -WWW: http://pear.php.net/package/Cache_Lite/
>> +WWW: http://pear.php.net/package/Cache_Lite
>
> Hi Martin,
>
> I'm afraid this change is wrong:
>
> - pear.php.net itself treats package entry page as a directory: Download,
>    Documentation, Bugs, Trackbacks links are implemented as subdirectories;
>    Main entry points to "http://pear.php.net/package/HTTP_Request2/" (note
>    the trailing slash)
>
> - PH section 3.2: "Include a URL to the official WWW homepage [...] with
>    WWW: (followed by single space) so that automated tools will work
>    correctly. If the URI is the root of the website or directory, it should
>    be terminated with a slash."
>
> These changes present in the next six commits of yours.  I think these
> parts should be backed out, and Mr. Rutkowski kindly advised to refresh
> his PH knowledge.
>
> ./danfe

This is a bit extreme and pedantic. The URL is fine as is. There
was little need to change it, and even less need to revert it
and cause grief to a contributor.

The modern web more and more makes trailing / more incorrect
than correct.

You have absolutely no way to tell if a URL is the "root of a directory"
with so many internal rewrites and dynamic URLs around the web now.

--
Regards,
Bryan Drewery



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?538DED66.6060501>