From owner-freebsd-toolchain@FreeBSD.ORG  Wed May  1 22:07:46 2013
Return-Path: <owner-freebsd-toolchain@FreeBSD.ORG>
Delivered-To: toolchain@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 4F4F6897;
 Wed,  1 May 2013 22:07:46 +0000 (UTC)
 (envelope-from brooks@lor.one-eyed-alien.net)
Received: from lor.one-eyed-alien.net (lor.one-eyed-alien.net [69.66.77.232])
 by mx1.freebsd.org (Postfix) with ESMTP id 8EED115C9;
 Wed,  1 May 2013 22:07:45 +0000 (UTC)
Received: from lor.one-eyed-alien.net (localhost [127.0.0.1])
 by lor.one-eyed-alien.net (8.14.5/8.14.5) with ESMTP id r41M7oCZ048647;
 Wed, 1 May 2013 17:07:50 -0500 (CDT)
 (envelope-from brooks@lor.one-eyed-alien.net)
Received: (from brooks@localhost)
 by lor.one-eyed-alien.net (8.14.5/8.14.5/Submit) id r41M7oli048646;
 Wed, 1 May 2013 17:07:50 -0500 (CDT) (envelope-from brooks)
Date: Wed, 1 May 2013 17:07:50 -0500
From: Brooks Davis <brooks@freebsd.org>
To: Garrett Cooper <yaneurabeya@gmail.com>
Subject: Re: Fwd: docs/178286: [PATCH] document the LOCAL_* vars in build(7)
Message-ID: <20130501220750.GD45806@lor.one-eyed-alien.net>
References: <201305012123.r41LNcEL048006@red.freebsd.org>
 <201305012130.r41LU031023258@freefall.freebsd.org>
 <CAGHfRMBtumFoaEDXavpo16z18bwHJC83O75CbcZpEvYcK7GCnA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGHfRMBtumFoaEDXavpo16z18bwHJC83O75CbcZpEvYcK7GCnA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: sjg@freebsd.org, toolchain@freebsd.org, joel@freebsd.org
X-BeenThere: freebsd-toolchain@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Maintenance of FreeBSD's integrated toolchain
 <freebsd-toolchain.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-toolchain>
List-Post: <mailto:freebsd-toolchain@freebsd.org>
List-Help: <mailto:freebsd-toolchain-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 May 2013 22:07:46 -0000


On Wed, May 01, 2013 at 02:35:17PM -0700, Garrett Cooper wrote:
> Hi Brooks and Joel,
>     I'd really appreciate if you guys could help out with this. I'm
> having to fix the Isilon build system due to severe lack of
> documentation in build(7). So many mistakes have been made because
> people don't understand how to write FreeBSD Makefiles...

One minor concern I have with this patch is documenting LOCAL_LIB_DIRS.
I've not posted to the lists yet, but now that I understand buildworld
better, I think I implemented it wrong.  It should have required that
the directories be also be listed in LOCAL_DIRS.  The reason is that you
could then have LOCAL_DIRS=foo and LOCAL_LIB_DIRS=foo/lib so you only
added one directory to the FreeBSD tree but could still have libs.  I
feared that someone might have started using this feature which would
mean we can't easily change that.  Is Isilon using it?

-- Brooks