From owner-dev-commits-src-main@freebsd.org Tue Jan 5 23:26:51 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 37C014D4C57; Tue, 5 Jan 2021 23:26:51 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D9TCv0tyKz3r0j; Tue, 5 Jan 2021 23:26:50 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-ot1-f54.google.com with SMTP id 11so1374875oty.9; Tue, 05 Jan 2021 15:26:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jwMGAnZPeGiz2QGUO+RmA4ZqehcDhs/c774a9Q/c6NI=; b=MLSmj14KuG5E8CajfCWxuU3OxNr3onVTFWaeKWtO/tjicaUPOAZPmJzr+bC4rxU+5C X9DsaP2QpwWnnQbez/VWiv2DalHjABLa4MTxDGmhFgBVb8MjZFmlE7pDRMy15JnhOzwI HSiL10FxLRvkoOQwl/LNG4N9cT3IW0e2KxfuCmw+LJnGkwJtdUhzKDUSqPuicRPNgxrH X9CuvGTdT6WTfxWHmbm5G9v84Ls7DjUwT4IQbfwzfx94z5OEci/QkKwxKjKSA8k51/ru Obay1VSCcZpRQI0sPn9nK/G7I8bxrjnVdfoYeCZYsewcskwGza2fl7HqL4S8+eDIC8uR WyyQ== X-Gm-Message-State: AOAM5310rPPxf9fcQH4EKVVY6/o8k8bRMSjRxgQP++jCz+g7EOUN0ZWe EP383vqgLvco1Ggu+ZWhZyaEFuI3HxjVtDh49Syl8d0WPWKI8w== X-Google-Smtp-Source: ABdhPJxmIi4s5MGEZZ2mEZl56JHBNYqcCpiU2PNFMl4KksbjxjLyukOGaJBdCoCK4DEFJ/7c15gQr25yzE49KxBbnWI= X-Received: by 2002:a9d:a61:: with SMTP id 88mr1424741otg.18.1609889209741; Tue, 05 Jan 2021 15:26:49 -0800 (PST) MIME-Version: 1.0 References: <202101030259.1032x5hV006606@gitrepo.freebsd.org> <20210105231100.GD94898@spindle.one-eyed-alien.net> In-Reply-To: <20210105231100.GD94898@spindle.one-eyed-alien.net> From: Alan Somers Date: Tue, 5 Jan 2021 16:26:38 -0700 Message-ID: Subject: Re: git: 022ca2fc7fe0 - main - Add aio_writev and aio_readv To: Brooks Davis Cc: Jessica Clarke , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" X-Rspamd-Queue-Id: 4D9TCv0tyKz3r0j X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2021 23:26:51 -0000 On Tue, Jan 5, 2021 at 4:11 PM Brooks Davis wrote: > On Sat, Jan 02, 2021 at 10:09:04PM -0700, Alan Somers wrote: > > On Sat, Jan 2, 2021 at 9:39 PM Jessica Clarke > wrote: > > > > > On 3 Jan 2021, at 02:59, Alan Somers wrote: > > > > diff --git a/sys/kern/syscalls.master b/sys/kern/syscalls.master > > > > index b7ea5e939635..aaa0a1277461 100644 > > > > --- a/sys/kern/syscalls.master > > > > +++ b/sys/kern/syscalls.master > > > > @@ -1477,7 +1477,17 @@ > > > > _In_opt_ struct sigevent *sig > > > > ); > > > > } > > > > -258-271 AUE_NULL UNIMPL nosys > > > > +258 AUE_AIO_WRITEV STD { > > > > + int aio_writev( > > > > + _Inout_ struct aiocb *aiocbp > > > > + ); > > > > + } > > > > +259 AUE_AIO_READV STD { > > > > + int aio_readv( > > > > + _Inout_ struct aiocb *aiocbp > > > > + ); > > > > + } > > > > +260-271 AUE_NULL UNIMPL nosys > > > > 272 AUE_O_GETDENTS COMPAT11 { > > > > int getdents( > > > > int fd, > > > > > > Should these not be added to the end? > > > > > > Jess > > > > > > > Should they be? I'm not aware of any requirement to add new syscalls to > > the end. I put them here so they would be next to the other AIO > syscalls. > > Yes. I'm sorry I missed this in the review. It's vastly easier to audit > these files and address conflicts if they are append-only. We're also > using these syscall numbers internally specifically to avoid conflicts > with new syscalls. Please move them to the end. > > I do see that we only provide extremely outdated advice in the comments > of syscalls.master. I'll take a look at improving this and the wiki > page. > > Thanks, > Brooks > Ok, I'll move them. And could you please elaborate on how we're "using these syscall numbers internally"? -Alan