From owner-freebsd-current@FreeBSD.ORG Thu Jul 3 20:30:27 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 23CE41065678 for ; Thu, 3 Jul 2008 20:30:27 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx23.fluidhosting.com [204.14.89.6]) by mx1.freebsd.org (Postfix) with ESMTP id BCF618FC13 for ; Thu, 3 Jul 2008 20:30:26 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 25987 invoked by uid 399); 3 Jul 2008 20:30:26 -0000 Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 3 Jul 2008 20:30:26 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <486D36E0.6080005@FreeBSD.org> Date: Thu, 03 Jul 2008 13:30:24 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.14 (X11/20080606) MIME-Version: 1.0 To: Kostik Belousov References: <486BFFE5.1010808@FreeBSD.org> <20080703193856.GS17123@deviant.kiev.zoral.com.ua> In-Reply-To: <20080703193856.GS17123@deviant.kiev.zoral.com.ua> X-Enigmail-Version: 0.95.6 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org Subject: Re: Panic using rsync to msdosfs filesystem X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jul 2008 20:30:27 -0000 Kostik Belousov wrote: > Looks like this is the first casuality of the -fstack-protector. D'oh! I seem to have a talent for such things. :-/ > Try this: > > diff --git a/sys/fs/msdosfs/msdosfs_vnops.c b/sys/fs/msdosfs/msdosfs_vnops.c > index 8a1484f..fe673e0 100644 > --- a/sys/fs/msdosfs/msdosfs_vnops.c > +++ b/sys/fs/msdosfs/msdosfs_vnops.c > @@ -982,7 +982,7 @@ msdosfs_rename(ap) > struct componentname *tcnp = ap->a_tcnp; > struct componentname *fcnp = ap->a_fcnp; > struct denode *ip, *xp, *dp, *zp; > - u_char toname[11], oldname[11]; > + u_char toname[12], oldname[11]; > u_long from_diroffset, to_diroffset; > u_char to_count; > int doingdirectory = 0, newparent = 0; So far so good! I managed to complete my rsync run with that patch in, and now I'm churning the disk with other stuff to make sure. So far so good! Thanks for getting on this one so fast. Doug -- This .signature sanitized for your protection