From owner-cvs-sys  Thu Jul 24 09:25:58 1997
Return-Path: <owner-cvs-sys>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id JAA08528
          for cvs-sys-outgoing; Thu, 24 Jul 1997 09:25:58 -0700 (PDT)
Received: from Ilsa.StevesCafe.com (Ilsa.StevesCafe.com [205.168.119.129])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id JAA08506;
          Thu, 24 Jul 1997 09:25:48 -0700 (PDT)
Received: from Ilsa.StevesCafe.com (localhost [127.0.0.1])
	by Ilsa.StevesCafe.com (8.8.6/8.8.5) with ESMTP id KAA21434;
	Thu, 24 Jul 1997 10:25:39 -0600 (MDT)
Message-Id: <199707241625.KAA21434@Ilsa.StevesCafe.com>
X-Mailer: exmh version 2.0gamma 1/27/96
From: Steve Passe <smp@csn.net>
To: Bruce Evans <bde@zeta.org.au>
cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG,
        fsmp@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/sys lock.h src/sys/i386/include param.h smp.h 
 src/sys/i386/isa apic_ipl.s apic_vector.s ipl.s src/sys/i386/i386 exception.s 
 mp_machdep.c mpapic.c
In-reply-to: Your message of "Thu, 24 Jul 1997 19:17:00 +1000."
             <199707240917.TAA14432@godzilla.zeta.org.au> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Thu, 24 Jul 1997 10:25:39 -0600
Sender: owner-cvs-sys@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

Hi,

> >  Modified files:
> >    sys/sys              lock.h 
> >  Log:
> >  Forced 32bit alignment of struct simple_lock.
> >  
> >  Revision  Changes    Path
> >  1.5       +3 -2      src/sys/sys/lock.h
> 
> Erm, this is bogus.  sys/lock.h is supposed to be machine-independent.  It
> should have no knowledge of machine-dependent alignment requirements.
> Alignment is guaranteed if alignment of the machine-dependent struct is
> guaranteed.

this I buy, I'll fix it...

---
> >  Modified files:
> >    sys/i386/include     param.h smp.h 
> >  Log:
> >  Forced 32bit alignment of struct simple_lock in param.h.
> 
> Alignment of the machine-dependent struct was already guaranteed, since
> the struct contains an int, and 32-bit alignment of ints is guaranteed
> in practice (although the CPU does not require it) since misalignment
> would be inefficient.

this I disagree with.  I think of it as a comment, forcing the observer
to actually think about how the variable is to be used.

--
Steve Passe	| powered by
smp@csn.net	|            Symmetric MultiProcessor FreeBSD