From nobody Wed Sep 6 05:34:15 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RgWJt2yNcz4shgp for ; Wed, 6 Sep 2023 05:34:22 +0000 (UTC) (envelope-from guru@unixarea.de) Received: from ms-10.1blu.de (ms-10.1blu.de [178.254.4.101]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RgWJt16BGz3gm8; Wed, 6 Sep 2023 05:34:22 +0000 (UTC) (envelope-from guru@unixarea.de) Authentication-Results: mx1.freebsd.org; none Received: from [188.174.50.15] (helo=localhost.unixarea.de) by ms-10.1blu.de with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qdlBC-0091as-3k; Wed, 06 Sep 2023 07:34:18 +0200 Received: from localhost.my.domain (localhost [127.0.0.1]) by localhost.unixarea.de (8.16.1/8.14.9) with ESMTPS id 3865YHwL006870 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 6 Sep 2023 07:34:17 +0200 (CEST) (envelope-from guru@unixarea.de) Received: (from guru@localhost) by localhost.my.domain (8.16.1/8.14.9/Submit) id 3865YFoF006869; Wed, 6 Sep 2023 07:34:15 +0200 (CEST) (envelope-from guru@unixarea.de) X-Authentication-Warning: localhost.my.domain: guru set sender to guru@unixarea.de using -f Date: Wed, 6 Sep 2023 07:34:15 +0200 From: Matthias Apitz To: Warner Losh Cc: sgk@troutmask.apl.washington.edu, Michael Gmelin , Alexander Motin , FreeBSD Current Subject: Re: 14.0-CURRENT boots fine but keyboard does not work Message-ID: Reply-To: Matthias Apitz Mail-Followup-To: Warner Losh , sgk@troutmask.apl.washington.edu, Michael Gmelin , Alexander Motin , FreeBSD Current References: <58E9D0C9-747F-4DEB-9DC7-5A2E8C54EABF@freebsd.org> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="wqmAerRmXjsN2nMD" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: FreeBSD 13.0-CURRENT r368166 (amd64) X-message-flag: Mails containing HTML will not be read! Please send only plain text. X-Con-Id: 51246 X-Con-U: 0-guru X-Originating-IP: 188.174.50.15 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:42730, ipnet:178.254.0.0/19, country:DE] X-Rspamd-Queue-Id: 4RgWJt16BGz3gm8 --wqmAerRmXjsN2nMD Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit El día martes, septiembre 05, 2023 a las 03:24:30p. m. -0600, Warner Losh escribió: > On Tue, Sep 5, 2023 at 2:22 PM Steve Kargl > wrote: > > > On Tue, Sep 05, 2023 at 01:29:34PM -0600, Warner Losh wrote: > > > + /* > > > + * Some Chromebooks don't confirm to the google comment above so do > > the > > > > s/confirm/conform ? > > > > > > > + * Chromebook workaround for all <= 2018 coreboot systems that have > > a > > > + * 'blank' version. At least once Acer "Peppy" chromebook has this > > > issue, > > > > s/once/one ? > > > > Yes. Thanks! Dashed off the comment in a hurry since I wanted to get the > patch out > there in a hurry... But that was kinda sloppy of me.. fixed. I've had to apply the patch manually (attached as context diff). With this the keyboard works also fine. Thanks matthias -- Matthias Apitz, ✉ guru@unixarea.de, http://www.unixarea.de/ +49-176-38902045 Public GnuPG key: http://www.unixarea.de/key.pub --wqmAerRmXjsN2nMD Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="atkbdc.c.diff" *** /usr/src/sys/dev/atkbdc/atkbdc.c.ORIG Sat Aug 5 12:50:44 2023 --- /usr/src/sys/dev/atkbdc/atkbdc.c Wed Sep 6 07:08:49 2023 *************** *** 149,154 **** --- 149,155 ---- char *maker = kern_getenv("smbios.system.maker"); char *product = kern_getenv("smbios.system.product"); char *version = kern_getenv("smbios.bios.version"); + char *reldate = kern_getenv("smbios.bios.reldate"); for (i = 0; i < nitems(quirks); i++) if (QUIRK_STR_EQUAL(quirks[i].bios_vendor, bios_vendor) && *************** *** 156,161 **** --- 157,173 ---- QUIRK_STR_EQUAL(quirks[i].product, product) && QUIRK_STR_MATCH(quirks[i].version, version)) return (quirks[i].quirk); + + /* + * Some Chromebooks don't conform to the google comment above so do the + * Chromebook workaround for all <= 2018 coreboot systems that have a + * 'blank' version. At least one Acer "Peppy" chromebook has this issue, + * with a reldate of 08/13/2014. + */ + if (QUIRK_STR_EQUAL("coreboot", bios_vendor) && + (version != NULL && *version == ' ') && + (reldate != NULL && strlen(reldate) >= 10 && strcmp(reldate + 6, "2018") <= 0)) + return (CHROMEBOOK_WORKAROUND); return (0); } --wqmAerRmXjsN2nMD--